Skip to content

Commit 6331d8f

Browse files
author
Triona Doyle
committed
address the coderabbit feedback
Signed-off-by: Triona Doyle <tekton@example.com>
1 parent 1a7ea58 commit 6331d8f

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

test/ui-e2e/src/pages/ApplicationsPage.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,12 @@ async syncApplication(appName: string, expectedResource: string = 'spring-petcli
9696

9797
//click 'all' to ensure all resource checkboxes are ticked across all Argo CD versions
9898
const allLink = this.page.getByRole('link', { name: 'all', exact: true });
99-
if (await allLink.isVisible()) {
100-
await allLink.click();
99+
try {
100+
await allLink.waitFor({ state: 'visible', timeout: 3000 });
101+
await allLink.click();
102+
} catch (error) {
103+
//all link didn't appear within 3 sec
101104
}
102-
103105
//click the main sync button
104106
await this.page.getByRole('button', { name: /^synchronize$/i }).first().click();
105107

0 commit comments

Comments
 (0)