Skip to content
This repository was archived by the owner on Sep 21, 2021. It is now read-only.

Commit cb5bc4c

Browse files
author
alex-treebeard
committed
add integ test for default param bug
1 parent 7499b79 commit cb5bc4c

3 files changed

Lines changed: 23 additions & 6 deletions

File tree

.github/workflows/action_integration_test.yml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,26 @@ jobs:
5858
path: "./integration-test/partially_passing"
5959
notebooks: "main.ipynb"
6060

61+
partially_passing_2:
62+
timeout-minutes: 20
63+
runs-on: ubuntu-latest
64+
steps:
65+
- uses: actions/checkout@v2
66+
- uses: actions/setup-python@v2
67+
- uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
68+
with:
69+
project_id: ${{ secrets.GCP_PROJECT_ID }}
70+
service_account_key: ${{ secrets.GCP_SA_KEY }}
71+
export_default_credentials: true
72+
- run: gcloud auth configure-docker
73+
- uses: "./"
74+
with:
75+
api-key: ${{ secrets.TREEBEARD_API_KEY }}
76+
docker-registry-prefix: gcr.io/treebeard-259315/tests
77+
debug: "true"
78+
path: "./integration-test/partially_passing"
79+
# notebooks configured in treebeard.yaml
80+
6181
failing_build:
6282
timeout-minutes: 20
6383
runs-on: ubuntu-latest

integration-test/partially_passing/treebeard.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,5 @@ ignore:
33
- .vscode
44
- .ipynb_checkpoints
55
- .pytest_cache
6+
notebooks:
7+
- main.ipynb

treebeard-lib/treebeard/notebooks/commands.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ def run_repo(
164164
treebeard_config.notebooks = notebooks
165165

166166
if ignore:
167-
treebeard_config.ignore = ignore
167+
treebeard_config.ignore = ignore + treebeard_config.output_dirs
168168

169169
if "TREEBEARD_START_TIME" not in os.environ:
170170
os.environ["TREEBEARD_START_TIME"] = get_time()
@@ -200,13 +200,8 @@ def run_repo(
200200
update_url=f"{api_url}/{treebeard_context.treebeard_env.run_path}/update",
201201
)
202202

203-
if treebeard_config:
204-
ignore += treebeard_config.ignore + treebeard_config.output_dirs
205-
206203
click.echo("🌲 Creating Project bundle")
207-
208204
temp_dir = tempfile.mkdtemp()
209-
210205
copy_tree(os.getcwd(), str(temp_dir), preserve_symlinks=1)
211206

212207
# Overwrite config with in-memory-modified

0 commit comments

Comments
 (0)