Add get_nj_max function similar to Sapporo Light#18
Merged
Conversation
For users of Sapporo Light backends, e.g. with PH4, attempted simulations with more than nj_max (currently set at 2^17) particles will yield an error in the "code.out" output file, if "redirection='file'" was set in the controlling Python script. This was implemented through AMUSE MR 1218. This commit has that same goal.
The first part of the code changes equivalent to AMUSE MR1218 have been added in the previous commit 13da4fe. 1) We increased the default value of "nj_max = 16384", which is way too low for many simulations. Instead, we set it to 2^18. The current default in Sapporo Light is 2^17. 2) Also, we added extra info to the error message if "address > nj_max".
Collaborator
Author
|
What remains to be added is the PH4 code changes from MR 1218 that propagate the value of |
HannoSpreeuw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address @LourensVeen 's comment in AMUSE issue 1209.