Enable make test#20
Open
HannoSpreeuw wants to merge 4 commits into
Open
Conversation
Add a top-level `test` target that builds the library and the test programs against it, then runs the GPU-vs-CPU correctness tests for the 4th-order, GRAPE5 (2nd-order) and 6th-order integrators. The target dispatches to the CUDA or OpenCL test Makefile based on the selected BACKEND, and sets LD_LIBRARY_PATH so the freshly built shared libraries are found at runtime. A `build-tests` target is also provided to compile the tests without running them, and `clean` now also cleans the tests directory. Fix two pre-existing bugs in tests/Makefile_ocl that prevented the OpenCL tests from building/running: link against libsapporo2 (not the old libsapporo name) and symlink kernels from src/OpenCL. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This reverts commit b2382a9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is cherry-picked commit c1292cb (now commit 17fb33e) -
Add 'make test' target to build and run correctness tests-plus commit c1adf9d -
Try to get an NVIDIA GPU if available.make clean; make all; clear; make testworks,i.e.
make clean; make all BACKEND=CUDA; make test BACKEND=CUDAcompletes without error.However,
make clean; make all BACKEND=OpenCL; make test BACKEND=OpenCLyieldswhen run on a cluster node with a NVIDIA RTX A5000 GPU after
module load opencl-nvidia/12.3on a cluster node when it gets to runningtest_gravity_block_ocl.That same command will result in
test_gravity_block_oclrunning "forever" - i.e. until it is killed - at 100% utilisation on a machine with CUDA 13.2 - more specifically ,nvcc --versiongivescuda_13.2.r13.2/compiler.37668154_0- and a NVIDIA RTX 4090 GPU:I have spent some time trying to fix this, but I did not succeed. Since OpenCL is not used often in AMUSE, I propose to merge.