Revert "fix: dvc ignore from scm root dir.\nSCM dvcignore is not required."

This reverts commit 6b36379.

Author: legendof-selda

dvc/dependency/base.py

@@ -1,6 +1,10 @@
+from typing import Optional
+
 from dvc.exceptions import DvcException
 from dvc.fs import download as fs_download
+from dvc.ignore import DvcIgnoreFilter
 from dvc.output import Output
+from dvc_objects.fs.scheme import Schemes
 
 
 class DependencyDoesNotExistError(DvcException):
@@ -27,6 +31,26 @@ class Dependency(Output):
     IsNotFileOrDirError: type[DvcException] = DependencyIsNotFileOrDirError
     IsStageFileError: type[DvcException] = DependencyIsStageFileError
 
+    @property
+    def dvcignore(self) -> Optional[DvcIgnoreFilter]:
+        """
+        For dependencies we override the dvcignore to be part of
+        SCM root as well. Outputs cannot be saved outside the DVC repo.
+        However, you can have dependency for subdir DVC repos.
+
+        Returns:
+            Optional[DvcIgnoreFilter]: DVC repo root or SCM root dvcignore.
+        """
+        if self.fs.protocol != Schemes.LOCAL:
+            return None
+
+        assert self.repo
+        if self.fs.isin_or_eq(self.fs_path, self.repo.root_dir):
+            return self.repo.dvcignore
+        if self.fs.isin_or_eq(self.fs_path, self.repo.scm.root_dir):
+            return self.repo.scm_dvcignore
+        return None
+
     def workspace_status(self) -> dict[str, str]:
         if self.fs.version_aware:
             old_fs_path = self.fs_path

dvc/repo/__init__.py

@@ -330,14 +330,13 @@ def scm_context(self) -> "SCMContext":
 
     @cached_property
     def dvcignore(self) -> DvcIgnoreFilter:
-        from dvc.scm import NoSCM
+        return DvcIgnoreFilter(self.fs, self.root_dir)
 
-        if isinstance(self.scm, NoSCM):
-            root_dir = self.root_dir
-        else:
-            root_dir = self.scm.root_dir
-
-        return DvcIgnoreFilter(self.fs, root_dir)
+    @cached_property
+    def scm_dvcignore(self) -> DvcIgnoreFilter:
+        if self.root_dir == self.scm.root_dir:
+            return self.dvcignore
+        return DvcIgnoreFilter(self.fs, self.scm.root_dir)
 
     def get_rev(self):
         from dvc.fs import GitFileSystem, LocalFileSystem