Conversation
skshetry
added
regression
skshetry
enabled auto-merge (squash)
October 27, 2025 16:59
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #10899 by correcting the shallow mode iteration logic for data status checks. The problem was that shallow mode wasn't properly iterating through nested directories when checking for entries not in remote storage.
Key Changes:
- Introduced a new
iter_indexfunction that properly handles shallow mode iteration by traversing directories until reaching entries with hash information - Updated
_get_entries_not_in_remoteto use the new iteration function instead of the built-initeritemsmethod
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dvc/repo/data.py | Added iter_index function to handle shallow mode directory traversal and updated remote check logic |
| tests/func/test_data_status.py | Added regression test verifying shallow mode correctly identifies tracked directories and their contents |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10899.