Skip to content

Typo on flatten-dict dependency#10953

Merged
skshetry merged 1 commit into
treeverse:mainfrom
weiji14:patch-1
Jan 7, 2026
Merged

Typo on flatten-dict dependency#10953
skshetry merged 1 commit into
treeverse:mainfrom
weiji14:patch-1

Conversation

@weiji14

@weiji14 weiji14 commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

Should be flatten-dict with a hyphen instead of underscore according to https://pypi.org/project/flatten-dict and https://github.com/ianlini/flatten-dict.

This has been tripping up the conda-forge auto-update bot since conda-forge/dvc-feedstock@6d439cf (had to manually remove flatten_dict in favour of flatten-dict).

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Should be flatten-dict with a hyphen instead of underscore according to https://pypi.org/project/flatten-dict/
@github-project-automation github-project-automation Bot moved this to Backlog in DVC Jan 6, 2026
@CLAassistant

CLAassistant commented Jan 6, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Jan 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.98%. Comparing base (2431ec6) to head (1090e12).
⚠️ Report is 181 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10953      +/-   ##
==========================================
+ Coverage   90.68%   90.98%   +0.30%     
==========================================
  Files         504      505       +1     
  Lines       39795    41083    +1288     
  Branches     3141     3255     +114     
==========================================
+ Hits        36087    37380    +1293     
- Misses       3042     3064      +22     
+ Partials      666      639      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skshetry

skshetry commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

@weiji14, in Python packaging, flatten_dict and flatten-dict are equal and gets normalized to flatten-dict. See Name Normalization. Could this be a bug in grayskull?

That said, I am okay with this changes.

@weiji14

weiji14 commented Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

Ah, didn't know that PyPI/pip handled that! Yes, conda is more sensitive (since it is not Python only). I did find conda/grayskull#228 and conda/grayskull#230 (comment), but those don't seemed to be actioned yet, so would prefer if we use flatten-dict with hyphen here 🙏

@skshetry skshetry enabled auto-merge (squash) January 7, 2026 04:04
@skshetry skshetry disabled auto-merge January 7, 2026 04:04
@skshetry skshetry merged commit dbc7531 into treeverse:main Jan 7, 2026
46 of 48 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in DVC Jan 7, 2026
@skshetry

skshetry commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

Thank you @weiji14 for fixing this, and also helping to migrate conda recipe to v1 format. 🙏🏽

@weiji14 weiji14 deleted the patch-1 branch January 7, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants