Add Zeitwerk eager loading check to CI#2
Closed
trevorturk wants to merge 1 commit intomainfrom
Closed
Conversation
Adds a validation step that runs Zeitwerk::Loader.eager_load_all after dependency installation to catch autoloading issues early in the CI pipeline. This check helps prevent production crashes by detecting: - Inflector configuration errors - Constant definition issues - Missing conditional checks for optional dependencies The check runs quickly (~2 seconds) before the test matrix, providing rapid feedback on structural issues. Note: This check currently fails due to upstream ruby_llm ActiveRecord dependency issues. See: - crmne/ruby_llm#504 - crmne/ruby_llm#505 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
Author
|
Closing - need to target upstream repository patvice/ruby_llm-mcp instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zeitwerk::Loader.eager_load_allvalidation to CI pipelineProblem
Without automated Zeitwerk eager loading validation, autoloading issues can slip into production causing crashes. These issues include:
Solution
Add a simple validation step that runs
Zeitwerk::Loader.eager_load_allafter dependency installation. This structural validation completes in ~2 seconds and provides rapid feedback before expensive test suites run.Upstream Dependencies
This PR is currently blocked and marked as draft because it depends on upstream fixes in ruby_llm:
Once these PRs are merged and a new version of ruby_llm is released, this PR can be updated and marked ready for review.
Testing
Currently fails with:
This is expected and will be resolved by ruby_llm#504.
🤖 Generated with Claude Code