Skip to content

Autodiscovery#675

Open
jnichols-git wants to merge 10 commits into
trickstercache:mainfrom
jnichols-git:disco-2
Open

Autodiscovery#675
jnichols-git wants to merge 10 commits into
trickstercache:mainfrom
jnichols-git:disco-2

Conversation

@jnichols-git

Copy link
Copy Markdown
Contributor

Unreasonably Large Pull Request 2

  • Config makes more sense; reduced unneeded options
  • Backends are now properly instantiated and added to the ALB pool

Drafting as there's currently a bug preventing access to the instantiated backends. Working on a fix and will un-draft once ready.

Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
… get instantiated

Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@coveralls

coveralls commented Jun 1, 2023

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 5148034125

  • 122 of 208 (58.65%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 92.377%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/backends/alb/pool/health.go 3 4 75.0%
pkg/backends/alb/options/options.go 1 3 33.33%
pkg/backends/options/options.go 2 4 50.0%
pkg/kube/selector.go 12 14 85.71%
pkg/kube/client.go 0 14 0.0%
pkg/kube/resource.go 89 106 83.96%
pkg/routing/routing.go 4 52 7.69%
Totals Coverage Status
Change from base Build 5008571097: -0.4%
Covered Lines: 17292
Relevant Lines: 18719

💛 - Coveralls

Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants