-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Expand file tree
/
Copy pathdrr.ts
More file actions
469 lines (403 loc) · 13.1 KB
/
drr.ts
File metadata and controls
469 lines (403 loc) · 13.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
import { createRedisClient, type Redis, type RedisOptions } from "@internal/redis";
import { BaseScheduler } from "../scheduler.js";
import type {
DRRSchedulerConfig,
DispatchSchedulerContext,
FairQueueKeyProducer,
SchedulerContext,
TenantQueues,
QueueWithScore,
} from "../types.js";
/**
* Deficit Round Robin (DRR) Scheduler.
*
* DRR ensures fair processing across tenants by:
* - Allocating a "quantum" of credits to each tenant per round
* - Accumulating unused credits as "deficit"
* - Processing from tenants with available deficit
* - Capping deficit to prevent starvation
*
* Key improvements over basic implementations:
* - Atomic deficit operations using Lua scripts
* - Efficient iteration through tenants
* - Automatic deficit cleanup for inactive tenants
*/
export class DRRScheduler extends BaseScheduler {
private redis: Redis;
private keys: FairQueueKeyProducer;
private quantum: number;
private maxDeficit: number;
private masterQueueLimit: number;
private logger: NonNullable<DRRSchedulerConfig["logger"]>;
constructor(private config: DRRSchedulerConfig) {
super();
this.redis = createRedisClient(config.redis);
this.keys = config.keys;
this.quantum = config.quantum;
this.maxDeficit = config.maxDeficit;
this.masterQueueLimit = config.masterQueueLimit ?? 1000;
this.logger = config.logger ?? {
debug: () => {},
error: () => {},
};
this.#registerCommands();
}
// ============================================================================
// FairScheduler Implementation
// ============================================================================
/**
* Select queues for processing using DRR algorithm.
*
* Algorithm:
* 1. Get all queues from the master shard
* 2. Group by tenant
* 3. Filter out tenants at concurrency capacity
* 4. Add quantum to each tenant's deficit (atomically)
* 5. Select queues from tenants with deficit >= 1
* 6. Order tenants by deficit (highest first for fairness)
*/
async selectQueues(
masterQueueShard: string,
consumerId: string,
context: SchedulerContext
): Promise<TenantQueues[]> {
// Get all queues from the master shard
const queues = await this.#getQueuesFromShard(masterQueueShard);
if (queues.length === 0) {
return [];
}
// Group queues by tenant
const queuesByTenant = this.groupQueuesByTenant(
queues.map((q) => ({ queueId: q.queueId, tenantId: q.tenantId }))
);
// Get unique tenant IDs
const tenantIds = Array.from(queuesByTenant.keys());
// Add quantum to all active tenants atomically
const deficits = await this.#addQuantumToTenants(tenantIds);
// Build tenant data with deficits
const tenantData: Array<{
tenantId: string;
deficit: number;
queues: string[];
isAtCapacity: boolean;
}> = await Promise.all(
tenantIds.map(async (tenantId, index) => {
const isAtCapacity = await context.isAtCapacity("tenant", tenantId);
return {
tenantId,
deficit: deficits[index] ?? 0,
queues: queuesByTenant.get(tenantId) ?? [],
isAtCapacity,
};
})
);
// Filter out tenants at capacity or with no deficit
const eligibleTenants = tenantData.filter(
(t) => !t.isAtCapacity && t.deficit >= 1
);
// Log tenants blocked by capacity
const blockedTenants = tenantData.filter((t) => t.isAtCapacity);
if (blockedTenants.length > 0) {
this.logger.debug("DRR: tenants blocked by concurrency", {
blockedCount: blockedTenants.length,
blockedTenants: blockedTenants.map((t) => t.tenantId),
});
}
// Sort by deficit (highest first for fairness)
eligibleTenants.sort((a, b) => b.deficit - a.deficit);
this.logger.debug("DRR: queue selection complete", {
totalQueues: queues.length,
totalTenants: tenantIds.length,
eligibleTenants: eligibleTenants.length,
topTenantDeficit: eligibleTenants[0]?.deficit,
});
// Convert to TenantQueues format
return eligibleTenants.map((t) => ({
tenantId: t.tenantId,
queues: t.queues,
}));
}
/**
* Select queues using the two-level tenant dispatch index.
*
* Algorithm:
* 1. ZRANGEBYSCORE on dispatch index (gets only tenants with queues - much smaller)
* 2. Add quantum to each tenant's deficit (atomically)
* 3. Check capacity as safety net (dispatch should only have tenants with capacity)
* 4. Select tenants with deficit >= 1, sorted by deficit (highest first)
* 5. For each tenant, fetch their queues from Level 2 index
*/
async selectQueuesFromDispatch(
dispatchShardKey: string,
consumerId: string,
context: DispatchSchedulerContext
): Promise<TenantQueues[]> {
// Level 1: Get tenants from dispatch index
const tenants = await this.#getTenantsFromDispatch(dispatchShardKey);
if (tenants.length === 0) {
return [];
}
const tenantIds = tenants.map((t) => t.tenantId);
// Add quantum to all active tenants atomically
const deficits = await this.#addQuantumToTenants(tenantIds);
// Build tenant data with deficits and capacity checks
const tenantData: Array<{
tenantId: string;
deficit: number;
isAtCapacity: boolean;
}> = await Promise.all(
tenantIds.map(async (tenantId, index) => {
// Capacity check as safety net - dispatch should already exclude at-capacity tenants
// once capacity-based pruning is implemented as a follow-up
const isAtCapacity = await context.isAtCapacity("tenant", tenantId);
return {
tenantId,
deficit: deficits[index] ?? 0,
isAtCapacity,
};
})
);
// Filter out tenants at capacity or with no deficit
const eligibleTenants = tenantData.filter((t) => !t.isAtCapacity && t.deficit >= 1);
// Sort by deficit (highest first for fairness)
eligibleTenants.sort((a, b) => b.deficit - a.deficit);
this.logger.debug("DRR dispatch: tenant selection complete", {
dispatchTenants: tenants.length,
eligibleTenants: eligibleTenants.length,
topTenantDeficit: eligibleTenants[0]?.deficit,
});
// Level 2: For each eligible tenant, fetch their queues
const result: TenantQueues[] = [];
for (const { tenantId } of eligibleTenants) {
const queues = await context.getQueuesForTenant(tenantId);
if (queues.length > 0) {
result.push({
tenantId,
queues: queues.map((q) => q.queueId),
});
}
}
return result;
}
/**
* Record that a message was processed from a tenant.
* Decrements the tenant's deficit.
*/
override async recordProcessed(tenantId: string, _queueId: string): Promise<void> {
await this.#decrementDeficit(tenantId);
}
/**
* Record that multiple messages were processed from a tenant.
* Decrements the tenant's deficit by count atomically.
*/
override async recordProcessedBatch(
tenantId: string,
_queueId: string,
count: number
): Promise<void> {
await this.#decrementDeficitBatch(tenantId, count);
}
override async close(): Promise<void> {
await this.redis.quit();
}
// ============================================================================
// Public Methods for Deficit Management
// ============================================================================
/**
* Get the current deficit for a tenant.
*/
async getDeficit(tenantId: string): Promise<number> {
const key = this.#deficitKey();
const value = await this.redis.hget(key, tenantId);
return value ? parseFloat(value) : 0;
}
/**
* Reset deficit for a tenant.
* Used when a tenant has no more active queues.
*/
async resetDeficit(tenantId: string): Promise<void> {
const key = this.#deficitKey();
await this.redis.hdel(key, tenantId);
}
/**
* Get all tenant deficits.
*/
async getAllDeficits(): Promise<Map<string, number>> {
const key = this.#deficitKey();
const data = await this.redis.hgetall(key);
const result = new Map<string, number>();
for (const [tenantId, value] of Object.entries(data)) {
result.set(tenantId, parseFloat(value));
}
return result;
}
// ============================================================================
// Private Methods
// ============================================================================
#deficitKey(): string {
// Use a fixed key for DRR deficit tracking
return `${this.keys.masterQueueKey(0).split(":")[0]}:drr:deficit`;
}
async #getTenantsFromDispatch(
dispatchKey: string
): Promise<Array<{ tenantId: string; score: number }>> {
const now = Date.now();
const results = await this.redis.zrangebyscore(
dispatchKey,
"-inf",
now,
"WITHSCORES",
"LIMIT",
0,
this.masterQueueLimit
);
const tenants: Array<{ tenantId: string; score: number }> = [];
for (let i = 0; i < results.length; i += 2) {
const tenantId = results[i];
const scoreStr = results[i + 1];
if (tenantId && scoreStr) {
tenants.push({
tenantId,
score: parseFloat(scoreStr),
});
}
}
return tenants;
}
async #getQueuesFromShard(shardKey: string): Promise<QueueWithScore[]> {
const now = Date.now();
const results = await this.redis.zrangebyscore(
shardKey,
"-inf",
now,
"WITHSCORES",
"LIMIT",
0,
this.masterQueueLimit
);
const queues: QueueWithScore[] = [];
for (let i = 0; i < results.length; i += 2) {
const queueId = results[i];
const scoreStr = results[i + 1];
if (queueId && scoreStr) {
queues.push({
queueId,
score: parseFloat(scoreStr),
tenantId: this.keys.extractTenantId(queueId),
});
}
}
return queues;
}
/**
* Add quantum to multiple tenants atomically.
* Returns the new deficit values.
*/
async #addQuantumToTenants(tenantIds: string[]): Promise<number[]> {
if (tenantIds.length === 0) {
return [];
}
const key = this.#deficitKey();
// Use Lua script for atomic quantum addition with capping
const results = await this.redis.drrAddQuantum(
key,
this.quantum.toString(),
this.maxDeficit.toString(),
...tenantIds
);
return results.map((r) => parseFloat(r));
}
/**
* Decrement deficit for a tenant atomically.
*/
async #decrementDeficit(tenantId: string): Promise<number> {
const key = this.#deficitKey();
// Use Lua script to decrement and ensure non-negative
const result = await this.redis.drrDecrementDeficit(key, tenantId);
return parseFloat(result);
}
/**
* Decrement deficit for a tenant by a count atomically.
*/
async #decrementDeficitBatch(tenantId: string, count: number): Promise<number> {
const key = this.#deficitKey();
// Use Lua script to decrement by count and ensure non-negative
const result = await this.redis.drrDecrementDeficitBatch(key, tenantId, count.toString());
return parseFloat(result);
}
#registerCommands(): void {
// Atomic quantum addition with capping for multiple tenants
this.redis.defineCommand("drrAddQuantum", {
numberOfKeys: 1,
lua: `
local deficitKey = KEYS[1]
local quantum = tonumber(ARGV[1])
local maxDeficit = tonumber(ARGV[2])
local results = {}
for i = 3, #ARGV do
local tenantId = ARGV[i]
-- Add quantum to deficit
local newDeficit = redis.call('HINCRBYFLOAT', deficitKey, tenantId, quantum)
newDeficit = tonumber(newDeficit)
-- Cap at maxDeficit
if newDeficit > maxDeficit then
redis.call('HSET', deficitKey, tenantId, maxDeficit)
newDeficit = maxDeficit
end
table.insert(results, tostring(newDeficit))
end
return results
`,
});
// Atomic deficit decrement with floor at 0
this.redis.defineCommand("drrDecrementDeficit", {
numberOfKeys: 1,
lua: `
local deficitKey = KEYS[1]
local tenantId = ARGV[1]
local newDeficit = redis.call('HINCRBYFLOAT', deficitKey, tenantId, -1)
newDeficit = tonumber(newDeficit)
-- Floor at 0
if newDeficit < 0 then
redis.call('HSET', deficitKey, tenantId, 0)
newDeficit = 0
end
return tostring(newDeficit)
`,
});
// Atomic deficit decrement by count with floor at 0
this.redis.defineCommand("drrDecrementDeficitBatch", {
numberOfKeys: 1,
lua: `
local deficitKey = KEYS[1]
local tenantId = ARGV[1]
local count = tonumber(ARGV[2])
local newDeficit = redis.call('HINCRBYFLOAT', deficitKey, tenantId, -count)
newDeficit = tonumber(newDeficit)
-- Floor at 0
if newDeficit < 0 then
redis.call('HSET', deficitKey, tenantId, 0)
newDeficit = 0
end
return tostring(newDeficit)
`,
});
}
}
// Extend Redis interface for custom commands
declare module "@internal/redis" {
interface RedisCommander<Context> {
drrAddQuantum(
deficitKey: string,
quantum: string,
maxDeficit: string,
...tenantIds: string[]
): Promise<string[]>;
drrDecrementDeficit(deficitKey: string, tenantId: string): Promise<string>;
drrDecrementDeficitBatch(
deficitKey: string,
tenantId: string,
count: string
): Promise<string>;
}
}