Skip to content

Commit 13d6813

Browse files
committed
fix: address review feedback - findFirst, cross-org state reset, stale closure
1 parent 67dd8b8 commit 13d6813

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

apps/webapp/app/components/admin/FeatureFlagsDialog.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ export function FeatureFlagsDialog({
5151
useEffect(() => {
5252
if (open && orgId) {
5353
setSaveError(null);
54+
setOverrides({});
55+
setInitialOverrides({});
5456
loadFetcher.load(`/admin/api/v2/orgs/${orgId}/feature-flags`);
5557
}
5658
}, [open, orgId]);

apps/webapp/app/routes/admin.api.v1.feature-flags.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export async function action({ request }: ActionFunctionArgs) {
1212
return json({ error: "Invalid or Missing API key" }, { status: 401 });
1313
}
1414

15-
const user = await prisma.user.findUnique({
15+
const user = await prisma.user.findFirst({
1616
where: {
1717
id: authenticationResult.userId,
1818
},

apps/webapp/app/routes/admin.feature-flags.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ export default function AdminFeatureFlagsRoute() {
128128
useEffect(() => {
129129
if (saveFetcher.data?.success) {
130130
setSaveError(null);
131-
setInitialValues({ ...values });
132131
setConfirmOpen(false);
133132
} else if (saveFetcher.data?.error) {
134133
setSaveError(saveFetcher.data.error);

0 commit comments

Comments
 (0)