coderabbit fixes

Author: ericallam

apps/webapp/app/components/runs/v3/ai/extractAISummarySpanData.ts

@@ -223,7 +223,6 @@ function parseProviderMetadata(
     if (!parsed || typeof parsed !== "object") return undefined;
 
     let serviceTier: string | undefined;
-    let resolvedProvider: string | undefined;
     let responseId: string | undefined;
 
     // OpenAI
@@ -237,8 +236,8 @@ function parseProviderMetadata(
       serviceTier = parsed.anthropic.usage.service_tier;
     }
 
-    return serviceTier || resolvedProvider || responseId
-      ? { serviceTier, resolvedProvider, responseId }
+    return serviceTier || responseId
+      ? { serviceTier, responseId }
       : undefined;
   } catch {
     return undefined;

apps/webapp/app/routes/api.v1.prompts.$slug.override.ts

@@ -28,7 +28,7 @@ export async function loader({ request }: LoaderFunctionArgs) {
   if (request.method.toUpperCase() === "OPTIONS") {
     return apiCors(request, json({}));
   }
-  return new Response(null, { status: 405 });
+  return apiCors(request, json({ error: "Method not allowed" }, { status: 405 }));
 }
 
 export async function action({ request, params }: ActionFunctionArgs) {

apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.prompts.$promptSlug.generations.ts

@@ -50,8 +50,17 @@ export const loader = async ({ request, params }: LoaderFunctionArgs) => {
   if (!environment) throw new Response("Environment not found", { status: 404 });
 
   const url = new URL(request.url);
-  const versions = url.searchParams.getAll("versions").filter(Boolean).map(Number).filter((n) => !isNaN(n));
+
+  const versions = url.searchParams
+    .getAll("versions")
+    .map(Number)
+    .filter((n) => Number.isInteger(n) && n > 0);
+
   const period = url.searchParams.get("period") ?? "7d";
+  if (!/^\d+[mhdw]$/.test(period)) {
+    return json({ generations: [], pagination: {} } satisfies GenerationsResponse);
+  }
+
   const fromTime = url.searchParams.get("from");
   const toTime = url.searchParams.get("to");
   const cursorParam = url.searchParams.get("cursor") ?? undefined;
@@ -60,6 +69,10 @@ export const loader = async ({ request, params }: LoaderFunctionArgs) => {
   const startTime = fromTime ? new Date(fromTime) : new Date(Date.now() - periodMs);
   const endTime = toTime ? new Date(toTime) : new Date();
 
+  if (isNaN(startTime.getTime()) || isNaN(endTime.getTime())) {
+    return json({ generations: [], pagination: {} } satisfies GenerationsResponse);
+  }
+
   const models = url.searchParams.getAll("models").filter(Boolean);
   const operations = url.searchParams.getAll("operations").filter(Boolean);
   const providers = url.searchParams.getAll("providers").filter(Boolean);

apps/webapp/app/v3/services/promptService.server.ts

@@ -4,23 +4,37 @@ import { BaseService, ServiceValidationError } from "./baseService.server";
 
 export class PromptService extends BaseService {
   async promoteVersion(promptId: string, versionId: string, options?: { sourceGuard?: boolean }) {
-    if (options?.sourceGuard) {
-      const target = await this._prisma.promptVersion.findUnique({
-        where: { id: versionId },
-      });
-      if (!target) {
-        throw new ServiceValidationError("Version not found", 404);
-      }
-      if (target.source !== "code") {
-        throw new ServiceValidationError(
-          "Only code-sourced versions can be promoted. Use the override API instead.",
-          400
-        );
-      }
+    const target = await this._prisma.promptVersion.findUnique({
+      where: { id: versionId },
+    });
+
+    if (!target) {
+      throw new ServiceValidationError("Version not found", 404);
+    }
+
+    if (target.promptId !== promptId) {
+      throw new ServiceValidationError("Version does not belong to this prompt", 400);
+    }
+
+    if (options?.sourceGuard && target.source !== "code") {
+      throw new ServiceValidationError(
+        "Only code-sourced versions can be promoted. Use the override API instead.",
+        400
+      );
     }
 
-    await this.#removeLabel(promptId, "current");
-    await this.#addLabel(versionId, "current");
+    await prisma.$transaction(async (tx) => {
+      await tx.$executeRaw`
+        UPDATE "prompt_versions"
+        SET "labels" = array_remove("labels", 'current')
+        WHERE "promptId" = ${promptId} AND 'current' = ANY("labels")
+      `;
+      await tx.$executeRaw`
+        UPDATE "prompt_versions"
+        SET "labels" = array_append("labels", 'current')
+        WHERE "id" = ${versionId} AND NOT ('current' = ANY("labels"))
+      `;
+    });
   }
 
   async createOverride(