a couple of tweaks and test updates

Author: ericallam

internal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.ts

@@ -213,7 +213,7 @@ describe("RunEngine getSnapshotsSince", () => {
 
         // The latest snapshot should have completedWaitpoints
         const latest = result![result!.length - 1];
-        expect(latest.completedWaitpoints.length).toBeGreaterThanOrEqual(0);
+        expect(latest.completedWaitpoints.length).toBeGreaterThan(0);
 
         // Earlier snapshots should have empty waitpoints (optimization)
         for (let i = 0; i < result!.length - 1; i++) {

internal-packages/run-engine/src/engine/tests/helpers/snapshotTestHelpers.ts

@@ -287,8 +287,9 @@ export async function setupTestScenario(
       checkpoints.push({ id: checkpoint.id });
     }
 
-    // Increment attempt number when entering EXECUTING
-    if (config.status === "EXECUTING" || config.status === "PENDING_EXECUTING") {
+    // Increment attempt number when entering a new execution attempt
+    // PENDING_EXECUTING is the entry point - EXECUTING follows within the same attempt
+    if (config.status === "PENDING_EXECUTING") {
       attemptNumber++;
     }