cleaner switch statement

Author: samejr

apps/webapp/app/components/errors/ErrorStatusMenu.tsx

@@ -32,16 +32,23 @@ const BugOffIcon = ({ className }: { className?: string }) => (
   <IconBugOffBase className={className} size={18} />
 );
 
-export function ignoreActionToastMessage(data: Record<string, string>): string | undefined {
-  if (data.action !== "ignore") return undefined;
-
-  const duration = data.duration ? Number(data.duration) : undefined;
-  if (!duration) return "Error ignored indefinitely";
-
-  const hours = duration / (60 * 60 * 1000);
-  if (hours < 24) return `Error ignored for ${hours} ${hours === 1 ? "hour" : "hours"}`;
-  const days = hours / 24;
-  return `Error ignored for ${days} ${days === 1 ? "day" : "days"}`;
+export function statusActionToastMessage(data: Record<string, string>): string {
+  switch (data.action) {
+    case "resolve":
+      return "Error marked as resolved";
+    case "unresolve":
+      return "Error marked as unresolved";
+    case "ignore": {
+      const duration = data.duration ? Number(data.duration) : undefined;
+      if (!duration) return "Error ignored indefinitely";
+      const hours = duration / (60 * 60 * 1000);
+      if (hours < 24) return `Error ignored for ${hours} ${hours === 1 ? "hour" : "hours"}`;
+      const days = hours / 24;
+      return `Error ignored for ${days} ${days === 1 ? "day" : "days"}`;
+    }
+    default:
+      return "Error status updated";
+  }
 }
 
 export function ErrorStatusMenuItems({

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors.$fingerprint/route.tsx

@@ -79,7 +79,7 @@ import { ErrorGroupActions } from "~/v3/services/errorGroupActions.server";
 import {
   ErrorStatusMenuItems,
   CustomIgnoreDialog,
-  ignoreActionToastMessage,
+  statusActionToastMessage,
 } from "~/components/errors/ErrorStatusMenu";
 import { useToast } from "~/components/primitives/Toast";
 
@@ -752,7 +752,7 @@ function ErrorStatusDropdown({
 
   const act = (data: Record<string, string>) => {
     setPopoverOpen(false);
-    pendingToast.current = ignoreActionToastMessage(data);
+    pendingToast.current = statusActionToastMessage(data);
     fetcher.submit(data, { method: "post" });
   };
 

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors._index/route.tsx

@@ -52,7 +52,7 @@ import { PopoverSectionHeader } from "~/components/primitives/Popover";
 import {
   ErrorStatusMenuItems,
   CustomIgnoreDialog,
-  ignoreActionToastMessage,
+  statusActionToastMessage,
 } from "~/components/errors/ErrorStatusMenu";
 import { useToast } from "~/components/primitives/Toast";
 import TooltipPortal from "~/components/primitives/TooltipPortal";
@@ -652,7 +652,7 @@ function ErrorActionsCell({
                 taskIdentifier={errorGroup.taskIdentifier}
                 onAction={(data) => {
                   close();
-                  pendingToast.current = ignoreActionToastMessage(data);
+                  pendingToast.current = statusActionToastMessage(data);
                   fetcher.submit(data, { method: "post", action: actionUrl });
                 }}
                 onCustomIgnore={() => {