Skip to content

Commit c731751

Browse files
committed
use proper input form components
1 parent dcd79d0 commit c731751

File tree

1 file changed

+23
-24
lines changed
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors.$fingerprint

1 file changed

+23
-24
lines changed

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors.$fingerprint/route.tsx

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ import { Spinner } from "~/components/primitives/Spinner";
5454
import { Paragraph } from "~/components/primitives/Paragraph";
5555
import { Callout } from "~/components/primitives/Callout";
5656
import { Header2, Header3 } from "~/components/primitives/Headers";
57+
import { Input } from "~/components/primitives/Input";
58+
import { InputGroup } from "~/components/primitives/InputGroup";
59+
import { Label } from "~/components/primitives/Label";
5760
import { formatDistanceToNow, isPast } from "date-fns";
5861

5962
import * as Property from "~/components/primitives/PropertyTable";
@@ -685,7 +688,6 @@ function IgnoredDetails({
685688
<RelativeDateTime
686689
date={state.ignoredAt}
687690
capitalize={false}
688-
className="text-text-dimmed"
689691
/>
690692
)}
691693
</Paragraph>
@@ -833,7 +835,7 @@ function ErrorStatusDropdown({
833835
</Popover>
834836

835837
<Dialog open={customIgnoreOpen} onOpenChange={setCustomIgnoreOpen}>
836-
<DialogContent>
838+
<DialogContent className="sm:max-w-md">
837839
<DialogHeader>
838840
<DialogTitle>Custom ignore condition</DialogTitle>
839841
</DialogHeader>
@@ -871,54 +873,51 @@ function CustomIgnoreForm({
871873
<input type="hidden" name="taskIdentifier" value={taskIdentifier} />
872874

873875
<div className="flex flex-col gap-4 py-4">
874-
<div className="flex flex-col gap-1">
875-
<label htmlFor="occurrenceRate" className="text-xs text-text-dimmed">
876+
<InputGroup fullWidth>
877+
<Label htmlFor="occurrenceRate" variant="small">
876878
Unignore when occurrence rate exceeds (per minute)
877-
</label>
878-
<input
879+
</Label>
880+
<Input
879881
id="occurrenceRate"
880882
name="occurrenceRate"
881883
type="number"
882884
min={1}
883-
className="rounded border border-charcoal-700 bg-charcoal-850 px-3 py-1.5 text-sm text-text-bright placeholder:text-text-dimmed focus:border-indigo-500 focus:outline-none"
884885
placeholder="e.g. 10"
885886
/>
886-
</div>
887+
</InputGroup>
887888

888-
<div className="flex flex-col gap-1">
889-
<label htmlFor="totalOccurrences" className="text-xs text-text-dimmed">
889+
<InputGroup fullWidth>
890+
<Label htmlFor="totalOccurrences" variant="small">
890891
Unignore when total occurrences exceed
891-
</label>
892-
<input
892+
</Label>
893+
<Input
893894
id="totalOccurrences"
894895
name="totalOccurrences"
895896
type="number"
896897
min={1}
897-
className="rounded border border-charcoal-700 bg-charcoal-850 px-3 py-1.5 text-sm text-text-bright placeholder:text-text-dimmed focus:border-indigo-500 focus:outline-none"
898898
placeholder="e.g. 100"
899899
/>
900-
</div>
900+
</InputGroup>
901901

902-
<div className="flex flex-col gap-1">
903-
<label htmlFor="reason" className="text-xs text-text-dimmed">
904-
Reason (optional)
905-
</label>
906-
<input
902+
<InputGroup fullWidth>
903+
<Label htmlFor="reason" variant="small" required={false}>
904+
Reason
905+
</Label>
906+
<Input
907907
id="reason"
908908
name="reason"
909909
type="text"
910-
className="rounded border border-charcoal-700 bg-charcoal-850 px-3 py-1.5 text-sm text-text-bright placeholder:text-text-dimmed focus:border-indigo-500 focus:outline-none"
911910
placeholder="e.g. Known flaky test"
912911
/>
913-
</div>
912+
</InputGroup>
914913
</div>
915914

916915
<DialogFooter>
917-
<Button variant="tertiary/small" type="button" onClick={onClose}>
916+
<Button variant="tertiary/medium" type="button" onClick={onClose}>
918917
Cancel
919918
</Button>
920-
<Button variant="primary/small" type="submit" disabled={isSubmitting}>
921-
{isSubmitting ? "Ignoring..." : "Ignore error"}
919+
<Button variant="primary/medium" type="submit" disabled={isSubmitting}>
920+
{isSubmitting ? "Ignoring" : "Ignore error"}
922921
</Button>
923922
</DialogFooter>
924923
</Form>

0 commit comments

Comments
 (0)