Skip to content

Commit c91c8b4

Browse files
samejrclaude
andcommitted
Fix CI: align syntheticTrace overridesBySpanId/queuedDuration with main
PR #3906 on main intentionally simplified these fields from `{} as Record<…>` / `undefined as number | undefined` to plain `undefined` (with a matching test update). The merge resolved the textual difference silently in favour of the HEAD-side older form, leaving the test (which came in from main) asserting against a value that no longer matched the implementation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 45ca03c commit c91c8b4

1 file changed

Lines changed: 3 additions & 8 deletions

File tree

apps/webapp/app/v3/mollifier/syntheticTrace.server.ts

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { millisecondsToNanoseconds } from "@trigger.dev/core/v3";
22
import { createTreeFromFlatItems, flattenTree } from "~/components/primitives/TreeView/TreeView";
33
import { createTimelineSpanEventsFromSpanEvents } from "~/utils/timelineSpanEvents";
4-
import type { SpanOverride, SpanSummary } from "~/v3/eventRepository/eventRepository.types";
4+
import type { SpanSummary } from "~/v3/eventRepository/eventRepository.types";
55
import type { SyntheticRun } from "./readFallback.server";
66

77
// Build a single-span trace for a buffered run so the run-detail page
@@ -79,13 +79,8 @@ export function buildSyntheticTraceForBufferedRun(run: SyntheticRun) {
7979
duration: totalDuration,
8080
rootStartedAt: tree?.data.startTime,
8181
startedAt: null,
82-
// Typed as `number | undefined` (not the literal `undefined`) so the
83-
// field survives `typedjson`'s `JsonifyObject` and stays in the route
84-
// loader's serialized trace shape — matches `RunPresenter`'s shape.
85-
// Buffered runs have no startedAt yet, so the runtime value stays
86-
// undefined.
87-
queuedDuration: undefined as number | undefined,
88-
overridesBySpanId: {} as Record<string, SpanOverride>,
82+
queuedDuration: undefined,
83+
overridesBySpanId: undefined,
8984
linkedRunIdBySpanId: {} as Record<string, string>,
9085
};
9186
}

0 commit comments

Comments
 (0)