Skip to content

Commit ec9f6df

Browse files
committed
Make sure the toast displays when saving form
1 parent 70b737e commit ec9f6df

File tree

1 file changed

+22
-18
lines changed

1 file changed

+22
-18
lines changed

apps/webapp/app/components/errors/ConfigureErrorAlerts.tsx

Lines changed: 22 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,13 @@ export function ConfigureErrorAlerts({
133133
/>
134134
</div>
135135

136-
<div className="flex-1 overflow-y-auto scrollbar-thin scrollbar-track-transparent scrollbar-thumb-charcoal-600">
137-
<fetcher.Form method="post" action={formAction} {...form.props}>
136+
<fetcher.Form
137+
method="post"
138+
action={formAction}
139+
{...form.props}
140+
className="contents"
141+
>
142+
<div className="flex-1 overflow-y-auto scrollbar-thin scrollbar-track-transparent scrollbar-thumb-charcoal-600">
138143
<Fieldset className="flex flex-col gap-4 p-4">
139144
<div className="flex flex-col">
140145
<Header3>Receive alerts when</Header3>
@@ -328,23 +333,22 @@ export function ConfigureErrorAlerts({
328333

329334
<FormError>{form.error}</FormError>
330335
</Fieldset>
331-
</fetcher.Form>
332-
</div>
336+
</div>
333337

334-
<div className="flex items-center justify-between border-t border-grid-bright px-3 py-3">
335-
<LinkButton variant="secondary/medium" to={closeHref}>
336-
Cancel
337-
</LinkButton>
338-
<Button
339-
variant="primary/medium"
340-
type="submit"
341-
form="configure-error-alerts"
342-
disabled={isSubmitting}
343-
isLoading={isSubmitting}
344-
>
345-
{isSubmitting ? "Saving…" : "Save"}
346-
</Button>
347-
</div>
338+
<div className="flex items-center justify-between border-t border-grid-bright px-3 py-3">
339+
<LinkButton variant="secondary/medium" to={closeHref}>
340+
Cancel
341+
</LinkButton>
342+
<Button
343+
variant="primary/medium"
344+
type="submit"
345+
disabled={isSubmitting}
346+
isLoading={isSubmitting}
347+
>
348+
{isSubmitting ? "Saving…" : "Save"}
349+
</Button>
350+
</div>
351+
</fetcher.Form>
348352
</div>
349353
);
350354
}

0 commit comments

Comments
 (0)