Skip to content

Commit f129288

Browse files
committed
ifNotFinite fix
1 parent 9ef7e2a commit f129288

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

internal-packages/clickhouse/src/tsqlFunctions.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -692,9 +692,7 @@ describe("TSQL Function Smoke Tests", () => {
692692
await runCases(client, [
693693
["isFinite", "SELECT isFinite(1.0) AS r FROM task_runs"],
694694
["isInfinite", "SELECT isInfinite(1.0 / 0) AS r FROM task_runs"],
695-
// ifNotFinite: TSQL definition has maxArgs: 1, but ClickHouse expects 2.
696-
// Skipped until the function definition is fixed.
697-
// ["ifNotFinite", "SELECT ifNotFinite(1.0 / 0, 0) AS r FROM task_runs"],
695+
["ifNotFinite", "SELECT ifNotFinite(1.0 / 0, 0) AS r FROM task_runs"],
698696
["isNaN", "SELECT isNaN(0.0 / 0) AS r FROM task_runs"],
699697
["bar", "SELECT bar(usage_duration_ms, 0, 10000, 20) AS r FROM task_runs"],
700698
[

internal-packages/tsql/src/query/functions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ export const TSQL_CLICKHOUSE_FUNCTIONS: Record<string, TSQLFunctionMeta> = {
445445
// Other functions
446446
isFinite: { clickhouseName: "isFinite", minArgs: 1, maxArgs: 1 },
447447
isInfinite: { clickhouseName: "isInfinite", minArgs: 1, maxArgs: 1 },
448-
ifNotFinite: { clickhouseName: "ifNotFinite", minArgs: 1, maxArgs: 1 },
448+
ifNotFinite: { clickhouseName: "ifNotFinite", minArgs: 2, maxArgs: 2 },
449449
isNaN: { clickhouseName: "isNaN", minArgs: 1, maxArgs: 1 },
450450
bar: { clickhouseName: "bar", minArgs: 4, maxArgs: 4 },
451451
transform: { clickhouseName: "transform", minArgs: 3, maxArgs: 4 },

0 commit comments

Comments
 (0)