|
| 1 | +# Consolidated Bug Fixes |
| 2 | + |
| 3 | +This PR combines fixes for several independent issues identified in the codebase, covering CLI stability, deployment/build reliability, and runtime correctness. |
| 4 | + |
| 5 | +## Fixes |
| 6 | + |
| 7 | +| Issue / Feature | Description | |
| 8 | +|-----------------|-------------| |
| 9 | +| **Orphaned Workers** | Fixes `trigger dev` leaving orphaned `trigger-dev-run-worker` processes by ensuring graceful shutdown on `SIGINT`/`SIGTERM` and robust process cleanup. | |
| 10 | +| **Sentry Interception** | Fixes `ConsoleInterceptor` swallowing logs when Sentry (or other monkey-patchers) are present by delegating to the original preserved console methods. | |
| 11 | +| **Engine Strictness** | Fixes deployment failures on GitHub Integration when `engines.node` is strict (e.g. "22") by passing `--no-engine-strict` (and equivalents) during the `trigger deploy` build phase. | |
| 12 | +| **Docker Hub Rate Limits** | Adds support for `DOCKER_USERNAME` and `DOCKER_PASSWORD` in `buildImage.ts` to authenticate with Docker Hub and avoid rate limits during native builds. | |
| 13 | +| **Dead Process Hang** | Fixes a hang in `TaskRunProcess.execute()` by checking specific process connectivity before attempting to send IPC messages. | |
| 14 | +| **Superjson ESM** | Bundles `superjson` into `packages/core/src/v3/vendor` to resolve `ERR_REQUIRE_ESM` issues in certain environments (Lambda, Node <22.12). | |
| 15 | +| **Realtime Hooks** | Fixes premature firing of `onComplete` in `useRealtime` hooks when the stream disconnects but the run hasn't actually finished. | |
| 16 | +| **Stream Targets** | Aligns `getRunIdForOptions` logic between SDK and Core to ensure Consistent semantic targets for streams. | |
| 17 | +| **Hook Exports** | Exports `AnyOnStartAttemptHookFunction` from `trigger-sdk` to allow proper typing of `onStartAttempt`. | |
| 18 | + |
| 19 | +## Verification |
| 20 | + |
| 21 | +### Automated Verification |
| 22 | +- **Engine Strictness**: Pass in `packages/cli-v3/src/commands/update.test.ts`. |
| 23 | +- **Superjson**: Validated via reproduction scripts importing the vendored bundle in both ESM and CJS modes. |
| 24 | +- **Sentry**: Validated via `repro_2900_sentry.ts` script ensuring logs flow through Sentry patches. |
| 25 | + |
| 26 | +### Manual Verification |
| 27 | +- **Orphaned Workers**: Verified locally by interrupting `trigger dev` and observing process cleanup. |
| 28 | +- **Docker Hub**: Verified code logic correctly identifies env vars and executes login. |
| 29 | +- **React Hooks & Streams**: Verified by code review of the corrected logic matching the intended fix. |
| 30 | + |
| 31 | +## Changesets |
| 32 | +- `fix-orphaned-workers-2909` |
| 33 | +- `fix-sentry-console-interceptor-2900` |
| 34 | +- `fix-github-install-node-version-2913` |
| 35 | +- `fix-docker-hub-rate-limit-2911` |
| 36 | +- `fix-dead-process-execute-hang` |
| 37 | +- `vendor-superjson-esm-fix` |
| 38 | +- `calm-hooks-wait` |
| 39 | +- `consistent-stream-targets` |
| 40 | +- `export-start-attempt-hook-type` |
0 commit comments