Skip to content

fix(react-hooks): prevent onComplete from firing prematurely when stream disconnects #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicktrn merged 4 commits into from
Jan 27, 2026
Merged

fix(react-hooks): prevent onComplete from firing prematurely when stream disconnects #2929

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12cfa0d
fix(react-hooks): prevent onComplete from firing prematurely when str…
github-actions[bot] Jan 9, 2026
3543031
Merge branch 'main' into claude/issue-2856-20260109-1025
nicktrn Jan 23, 2026
f4d65dd
chore: add changeset for react-hooks fix
nicktrn Jan 25, 2026
a7d7535
Merge remote-tracking branch 'origin/main' into claude/issue-2856-202…
nicktrn Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/react-hooks/src/hooks/useRealtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,10 @@ export function useRealtimeRun<TTask extends AnyTask>(
const hasCalledOnCompleteRef = useRef(false);

// Effect to handle onComplete callback
// Only call onComplete when the run has actually finished (has finishedAt),
// not just when the subscription stream ends (which can happen due to network issues)
useEffect(() => {
if (isComplete && run && options?.onComplete && !hasCalledOnCompleteRef.current) {
if (isComplete && run?.finishedAt && options?.onComplete && !hasCalledOnCompleteRef.current) {
options.onComplete(run, error);
hasCalledOnCompleteRef.current = true;
}
Expand Down Expand Up @@ -313,8 +315,10 @@ export function useRealtimeRunWithStreams<
const hasCalledOnCompleteRef = useRef(false);

// Effect to handle onComplete callback
// Only call onComplete when the run has actually finished (has finishedAt),
// not just when the subscription stream ends (which can happen due to network issues)
useEffect(() => {
if (isComplete && run && options?.onComplete && !hasCalledOnCompleteRef.current) {
if (isComplete && run?.finishedAt && options?.onComplete && !hasCalledOnCompleteRef.current) {
options.onComplete(run, error);
hasCalledOnCompleteRef.current = true;
}
Expand Down