-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(redis-worker): batched pop in MollifierDrainer for fast single-env drains #3797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fd1a739
docs: security fix pipeline design spec
d-cs eaae99e
docs: phase 1 implementation plan for sec-fix-pipeline skeleton
d-cs 16ad47e
feat(redis-worker): per-env batched pop in MollifierDrainer
d-cs 9eda059
chore: remove stale docs/superpowers scratch
d-cs 9378033
docs: shorten changelog entries to one line
d-cs 3bceb54
fix(redis-worker): bound DRAINING blast radius with worker-pool drain
d-cs 18e64f6
test(redis-worker): restore real concurrency in batch tests with race…
d-cs 1c6fc45
docs: clarify drainBatchSize changeset wording
d-cs 4bdd70d
fix(redis-worker): make per-env pop-failure increment idempotent
d-cs 1ce477c
Merge branch 'main' of https://github.com/triggerdotdev/trigger.dev i…
d-cs 2d185ab
feat(redis-worker,webapp): observability index for in-flight DRAINING…
d-cs 667218a
docs: extend changelog entries to cover the draining tracker / gauge
d-cs 081f73e
Merge branch 'main' into feat/mollifier-drain-batch
d-cs d38b449
chore: drop stale changesets from earlier mollifier PRs
d-cs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@trigger.dev/redis-worker": patch | ||
| --- | ||
|
|
||
| `MollifierDrainer` accepts a `drainBatchSize` option (default 1) that lets a single env drain at full `concurrency`-parallelism per tick. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| area: webapp | ||
| type: improvement | ||
| --- | ||
|
|
||
| Wire `TRIGGER_MOLLIFIER_DRAIN_BATCH_SIZE` (default 50) so single-env bursts drain at the full `DRAIN_CONCURRENCY` budget per tick instead of one entry per tick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.