fix: add lost compile kwargs#586
Merged
Merged
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Contributor
Author
hashhar
approved these changes
Feb 4, 2026
Member
wendigo
approved these changes
Feb 4, 2026
damian3031
approved these changes
Feb 5, 2026
Contributor
Author
|
@wendigo @damian3031 @hashhar thanks for merge, will you be able to release new version so we can drop our local fixes for the matter? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
trino.sqlalchemy.compiler.TrinoSQLCompiler.compile_ignore_nullscauses all compliations of funcs that being overridden to ignorecompile_kwargs.Non-technical explanation
#429 introduced bug where SqlAlchemy func compilation with kwargs is broken for functions first_value, last_value, nth_value, lead, lag.
Release notes
(x) This is not user-visible or docs only and no release notes are required.