Skip to content

Commit d557591

Browse files
mc-nvnv-anants
andauthored
Enable support for Ubuntu 24.04 (#51) (#52)
* Build Updates for Ubuntu24.04 (#50) * update cmake version for u24 * temp: override client repo tag * remove werror * fix0 - redefinition error Error - ``` /tmp/build/javacpp-presets/tritonserver/cppbuild/tritonbuild/developer_tools/server/include/triton/developer_tools/server_wrapper.h:413:58: error: redefinition of default argument for 'typename std::enable_if<(! std::is_same<typename std::iterator_traits< <template-parameter-1-1> >::value_type, std::__cxx11::basic_string<char> >::value)>::type* <anonymous>' 413 | std::string>::value>::type* = nullptr> | ^~~~~~~ /tmp/build/javacpp-presets/tritonserver/cppbuild/tritonbuild/developer_tools/server/include/triton/developer_tools/server_wrapper.h:316:41: note: original definition appeared here 316 | std::string>::value>::type* = nullptr> | ^~~~~~~ make[2]: *** [CMakeFiles/triton-developer_tools-server.dir/build.make:76: CMakeFiles/triton-developer_tools-server.dir/src/server_wrapper.cc.o] Error 1 ``` * fix1 - redefinition error * Revert "temp: override client repo tag" This reverts commit 9f8ea3d. * Update server/install_dependencies_and_build.sh --------- Co-authored-by: Anant Sharma <anants@nvidia.com>
1 parent d9e1d57 commit d557591

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

server/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ target_compile_options(
121121
triton-developer_tools-server
122122
PRIVATE
123123
$<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:
124-
-Wall -Wextra -Wno-unused-parameter -Werror>
124+
-Wall -Wextra -Wno-unused-parameter>
125125
$<$<CXX_COMPILER_ID:MSVC>:/Wall /D_WIN32_WINNT=0x0A00 /EHsc>
126126
)
127127

server/include/triton/developer_tools/server_wrapper.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ std::string ModelReadyStateString(const ModelReadyState& state);
381381
template <
382382
typename Iterator, typename std::enable_if<std::is_same<
383383
typename std::iterator_traits<Iterator>::value_type,
384-
std::string>::value>::type* = nullptr>
384+
std::string>::value>::type*>
385385
void
386386
InferRequest::AddInput(
387387
const std::string& name, const Iterator begin, const Iterator end,
@@ -410,7 +410,7 @@ InferRequest::AddInput(
410410
template <
411411
typename Iterator, typename std::enable_if<!std::is_same<
412412
typename std::iterator_traits<Iterator>::value_type,
413-
std::string>::value>::type* = nullptr>
413+
std::string>::value>::type*>
414414
void
415415
InferRequest::AddInput(
416416
const std::string& name, const Iterator begin, const Iterator end,

server/install_dependencies_and_build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ apt update -q=2 \
3636
&& . /etc/os-release \
3737
&& echo "deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitware.com/ubuntu/ $UBUNTU_CODENAME main" | tee /etc/apt/sources.list.d/kitware.list >/dev/null \
3838
&& apt-get update -q=2 \
39-
&& apt-get install -y --no-install-recommends cmake=3.27.7* cmake-data=3.27.7* \
39+
&& apt-get install -y --no-install-recommends cmake=3.28.3* cmake-data=3.28.3* \
4040
&& cmake --version
4141

4242
# Install developer tools

0 commit comments

Comments
 (0)