Skip to content

ci: migrate the centralized add-license hook to the org .github repository #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mc-nv wants to merge 16 commits into
base: main
Choose a base branch
from
+28 −417
Open

ci: migrate the centralized add-license hook to the org .github repository #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f92aef4
ci: add centralized add-spdx-license hook
mc-nv Jul 17, 2026
bef38e6
ci: run in-tree hook versions in this repo's own pre-commit config
mc-nv Jul 18, 2026
0060976
chore: align SPDX copyright text with NVIDIA Legal boilerplate
mc-nv Jul 18, 2026
c2f2363
ci: drop the add-spdx-license hook, keep add-license hardening
mc-nv Jul 18, 2026
81c12bc
ci: drop the add-spdx-license hook, keep add-license hardening
mc-nv Jul 18, 2026
dd3aa7a
ci: route issue reporting to the server repository
mc-nv Jul 18, 2026
be09477
ci: share the server repository's PR templates
mc-nv Jul 18, 2026
3c84d22
ci: migrate the centralized add-license hook to the org .github repo
mc-nv Jul 20, 2026
0a4de80
ci: bump conventional-pr workflow to v1.1.0
mc-nv Jul 20, 2026
c263b82
ci: bump conventional-pr workflow to v1.2.1
mc-nv Jul 20, 2026
81110a8
ci: bump conventional-pr workflow to v1.2.2
mc-nv Jul 20, 2026
53a03dd
ci: bump conventional-pr workflow to v1.3.0
mc-nv Jul 20, 2026
b9014e7
ci: bump conventional-pr workflow to v1.3.1
mc-nv Jul 20, 2026
9d59291
ci: pin org .github hooks and workflow to the same tag (v1.3.1)
mc-nv Jul 20, 2026
0659fbd
ci: bump org .github hooks and workflow to v1.4.0
mc-nv Jul 21, 2026
d13254c
ci: bump org .github hooks and workflow to v1.4.1
mc-nv Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions .pre-commit-hooks.yaml → .github/workflows/conventional-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,18 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

- id: add-license
name: Add License
entry: tools/add_copyright.py
language: script
stages: [pre-commit]
verbose: true
require_serial: true
# Thin caller: the logic lives in the org-wide reusable workflow, pinned by
# tag. Workflow changes ship as a new tag in the .github repository plus a
# one-line rev bump here (tags are write-once, never moved).

name: conventional-pr

on:
pull_request:
types: [opened, edited, synchronize, reopened]

jobs:
conventional-pr:
permissions:
pull-requests: write
uses: triton-inference-server/.github/.github/workflows/conventional-pr.yml@v1.4.1
15 changes: 13 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

default_install_hook_types: [pre-commit, commit-msg]

repos:
- repo: https://github.com/PyCQA/isort
rev: 5.12.0
Expand Down Expand Up @@ -54,6 +56,15 @@ repos:
additional_dependencies: [tomli]
args: ["--toml", "pyproject.toml"]
exclude: (?x)^(.*stemmer.*|.*stop_words.*|^CHANGELOG.md$)
# Validates commit messages against the Conventional Commits format

@yinggeh yinggeh Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: This hook only validates commit messages. It does not check pull request titles. And we don't need to add rules to the commits because everything will be squashed at the end.

@mc-nv mc-nv Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct on both points, and that's the intended division of labor: PR titles are validated in CI by the org-wide conventional-pr reusable workflow (triton-inference-server/.github, pinned @v1.4.1) — it gates the title, since squash-merge makes the title the commit that lands on main, and it also applies the type labels. This commit-msg hook is the local fast-feedback complement so contributors catch format issues before pushing, and conforming commit subjects additionally feed the PR's multi-type labeling. If the team prefers title-only enforcement, dropping the commit-msg hook is a one-line change per repo — happy to do that in a follow-up if you'd rather not have both.

# (<commit_type>: <title>); PR titles are validated org-wide by the
# conventional-pr reusable workflow.
- repo: https://github.com/compilerla/conventional-pre-commit
rev: v4.4.0
hooks:
- id: conventional-pre-commit
stages: [commit-msg]
args: [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]
# More details about these pre-commit hooks here:
# https://pre-commit.com/hooks.html
- repo: https://github.com/pre-commit/pre-commit-hooks
Expand All @@ -72,7 +83,7 @@ repos:
- id: requirements-txt-fixer
- id: trailing-whitespace

- repo: https://github.com/triton-inference-server/developer_tools
rev: v0.1.0
- repo: https://github.com/triton-inference-server/.github
rev: v1.4.1
hooks:
- id: add-license
Loading
Loading