Skip to content

Commit e45da7e

Browse files
committed
ci: share the server repository's PR templates
Adopt the canonical PR template set from triton-inference-server/server (default chooser plus internal/external contribution templates) so every repository presents the same PR experience. The manual "Commit Type" checkbox section is dropped — the conventional-pre-commit hook (commit-msg stage) enforces it automatically. TRI-1100
1 parent 0d87537 commit e45da7e

3 files changed

Lines changed: 81 additions & 14 deletions

File tree

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
#### What does the PR do?
2+
<!-- Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.-->
3+
4+
#### Checklist
5+
- [ ] I have read the [Contribution guidelines](#../../CONTRIBUTING.md) and signed the [Contributor License
6+
Agreement](https://github.com/NVIDIA/triton-inference-server/blob/master/Triton-CCLA-v1.pdf)
7+
- [ ] PR title reflects the change and is of format `<commit_type>: <Title>`
8+
- [ ] Changes are described in the pull request.
9+
- [ ] Related issues are referenced.
10+
- [ ] Populated [github labels](https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels) field
11+
- [ ] Added [test plan](#test-plan) and verified test passes.
12+
- [ ] Verified that the PR passes existing CI.
13+
- [ ] I ran pre-commit locally (`pre-commit install, pre-commit run --all`)
14+
- [ ] Verified copyright is correct on all changed files.
15+
- [ ] Added _succinct_ git squash message before merging [ref](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
16+
- [ ] All template sections are filled out.
17+
- [ ] Optional: Additional screenshots for behavior/output changes with before/after.
18+
19+
#### Related PRs:
20+
<!-- Related PRs from other Repositories -->
21+
22+
#### Where should the reviewer start?
23+
<!-- call out specific files that should be looked at closely -->
24+
25+
#### Test plan:
26+
<!-- list steps to verify feature works -->
27+
<!-- were e2e tests added?-->
28+
29+
#### Caveats:
30+
<!-- any limitations or possible things missing from this PR -->
31+
32+
#### Background
33+
<!-- e.g. what led to this change being made. this is optional extra information to help the reviewer -->
34+
35+
#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
36+
- closes GitHub issue: #xxx
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
#### What does the PR do?
2+
<!-- Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.-->
3+
4+
#### Checklist
5+
- [ ] PR title reflects the change and is of format `<commit_type>: <Title>`
6+
- [ ] Changes are described in the pull request.
7+
- [ ] Related issues are referenced.
8+
- [ ] Populated [github labels](https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels) field
9+
- [ ] Added [test plan](#test-plan) and verified test passes.
10+
- [ ] Verified that the PR passes existing CI.
11+
- [ ] Verified copyright is correct on all changed files.
12+
- [ ] Added _succinct_ git squash message before merging [ref](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
13+
- [ ] All template sections are filled out.
14+
- [ ] Optional: Additional screenshots for behavior/output changes with before/after.
15+
16+
#### Related PRs:
17+
<!-- Related PRs from other Repositories -->
18+
19+
#### Where should the reviewer start?
20+
<!-- call out specific files that should be looked at closely -->
21+
22+
#### Test plan:
23+
<!-- list steps to verify -->
24+
<!-- were e2e tests added?-->
25+
26+
- CI Pipeline ID:
27+
<!-- Only Pipeline ID and no direct link here -->
28+
29+
#### Caveats:
30+
<!-- any limitations or possible things missing from this PR -->
31+
32+
#### Background
33+
<!-- e.g. what led to this change being made. this is optional extra information to help the reviewer -->
34+
35+
#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
36+
- closes GitHub issue: #xxx

.github/pull_request_template.md

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,13 @@
1-
#### What does the PR do?
2-
<!-- Describe the change and the motivation behind it. -->
1+
Thanks for submitting a PR to Triton!
2+
Please go the the `Preview` tab above this description box and select the appropriate sub-template:
33

4-
#### Related Issues / PRs
5-
<!-- Use "Closes #xxx" / "Fixes #xxx" / "Resolves #xxx" for issues.
6-
Link related PRs from other triton-inference-server repositories. -->
4+
* [PR description template for Triton Engineers](?expand=1&template=pull_request_template_internal_contrib.md)
5+
* [PR description template for External Contributors](?expand=1&template=pull_request_template_external_contrib.md)
76

8-
#### Test plan
9-
<!-- How was this change verified? List steps, tests added, or CI evidence. -->
7+
If you already created the PR, please replace this message with one of
8+
* [External contribution template](https://raw.githubusercontent.com/triton-inference-server/server/main/.github/PULL_REQUEST_TEMPLATE/pull_request_template_external_contrib.md)
9+
* [Internal contribution template](https://raw.githubusercontent.com/triton-inference-server/server/main/.github/PULL_REQUEST_TEMPLATE/pull_request_template_internal_contrib.md)
10+
11+
and fill it out.
1012

11-
#### Caveats
12-
<!-- Optional: known limitations or follow-ups. -->
1313

14-
#### Checklist
15-
- [ ] PR title follows `<commit_type>: <Title>` (conventional commit — enforced by the `conventional-pre-commit` hook)
16-
- [ ] I ran `pre-commit install && pre-commit run --all-files` locally and it passes
17-
- [ ] Copyright header is correct on all changed files
18-
- [ ] External contributors: I have read the [Contribution guidelines](../CONTRIBUTING.md) and signed the [Contributor License Agreement](https://github.com/NVIDIA/triton-inference-server/blob/master/Triton-CCLA-v1.pdf)

0 commit comments

Comments
 (0)