fix: Fix SEGFAULT in BLS Model Loading#420
Merged
Merged
Conversation
This change contains the minimal change to avoid SEGFAULT failures during the BLS Model Loading test.
The crash itself is cause by deleting a shared-memory region's control allocation which can happen
when we somehow endup with handle{1} (the control region) in our accounting, and then delete it when
its refcount reaches zero.
This change does fix the root cause of how we're accounting for handle{1} (which we should never have).
whoisj
force-pushed
the
jwyman/tri-187-exception-in-bls_model_loading-test
branch
from
0461377 to
b49d9e2
Compare
yinggeh
reviewed
Nov 10, 2025
yinggeh
approved these changes
Nov 10, 2025
whoisj
deleted the
jwyman/tri-187-exception-in-bls_model_loading-test
branch
whoisj
added a commit
that referenced
this pull request
Nov 12, 2025
* fix: Fix SEGFAULT in BLS Model Loading
This change contains the minimal change to avoid SEGFAULT failures during the BLS Model Loading test.
The crash itself is cause by deleting a shared-memory region's control allocation which can happen
when we somehow endup with handle{1} (the control region) in our accounting, and then delete it when
its refcount reaches zero.
This change does fix the root cause of how we're accounting for handle{1} (which we should never have).
* rename variable
mc-nv
pushed a commit
that referenced
this pull request
Nov 12, 2025
* fix: Fix SEGFAULT in BLS Model Loading
This change contains the minimal change to avoid SEGFAULT failures during the BLS Model Loading test.
The crash itself is cause by deleting a shared-memory region's control allocation which can happen
when we somehow endup with handle{1} (the control region) in our accounting, and then delete it when
its refcount reaches zero.
This change does fix the root cause of how we're accounting for handle{1} (which we should never have).
* rename variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change contains the minimal change to avoid SEGFAULT failures during the BLS Model Loading test.
The crash itself is cause by deleting a shared-memory region's control allocation which can happen when we somehow endup with handle{1} (the control region) in our accounting, and then delete it when its refcount reaches zero.
This change does fix the root cause of how we're accounting for handle{1} (which we should never have).