fix: Prevent deadlock in decoupled BLS and use-after-free in async_exec pybind callback#439
Merged
pskiran1 merged 5 commits intoJun 16, 2026
Conversation
20 tasks
Vinya567
approved these changes
Jun 15, 2026
yinggeh
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following bugs in
pb_stub.cc:Deadlock in decoupled BLS with GPU tensors:
Stub::GetCUDAMemoryPoolAddressis called on theParentToStubMQMonitorthread, which also delivers decoupled BLS responses (ProcessBLSResponseDecoupled). After notifying the parent, it unconditionally blocked waiting for an acknowledgment (waiting_on_stub). On the success path the parent may itself be blocked waiting for a decoupled response that this now-blocked thread is supposed to deliver, creating a circular wait. This caused occasional hangs when a BLS model first returned GPU tensors, triggering CUDA pool initialization.Use-after-free in
async_execpybind callback:The async callback lambda captures the local stub
shared_ptrby reference ([&stub, ...]). Because stub is a local variable, it could be destroyed before the callback ran on the event loop, leaving a dangling reference and causing a use-after-free.CI: triton-inference-server/server#8830