ci: align pre-commit hooks and GitHub templates#449
Open
mc-nv wants to merge 15 commits into
Open
Conversation
Adopt the shared pre-commit baseline: two-line SPDX header, conventional commit message validation (commit-msg stage), and the centralized add-license / add-spdx-license hooks from developer_tools v0.2.0. Run pre-commit CI only on files modified by the PR, and roll out the standard issue templates and the simplified single PR template. TRI-1100
This was referenced Jul 18, 2026
Open
ci: align pre-commit hooks and GitHub templates
triton-inference-server/checksum_repository_agent#14
Open
Open
Legal's Copyright / License Header Guidance specifies the SPDX form without a comma after the year. TRI-1100
mc-nv
marked this pull request as ready for review
July 18, 2026 02:04
mc-nv
requested review from
Vinya567,
mattwittwer,
mudit-eng,
nv-rinig and
yinggeh
July 18, 2026 06:40
Vinya567
approved these changes
Jul 20, 2026
Adopt the shared pre-commit baseline: conventional-commit message validation (commit-msg stage) and the centralized add-license hook from the org .github repository (v1.0.0 - excludes .github/ templates and never rewrites LICENSE files). Run pre-commit CI only on files modified by the PR, and add the caller stub for the org-wide conventional-pr reusable workflow (PR title validation + type labeling). PR and issue templates are no longer stored per repository: they are inherited from the org-wide defaults in triton-inference-server/.github (issues route to the server repository). TRI-1100
Org-wide label color scheme and cherry-pick detection. TRI-1100
10 tasks
Human-readable type labels with enforced descriptions and colors. TRI-1100
github-actions
Bot
added
CI/CD
github-actions
Bot
added
the
chore
mc-nv
requested review from
Vinya567,
mattwittwer,
mudit-eng,
nv-rinig and
yinggeh
July 20, 2026 23:32
Vinya567
approved these changes
Jul 20, 2026
The add-license hook now fails when the LICENSE copyright year is stale. TRI-1100
Workflow files are license-processed again (only templates excluded); refresh the stale copyright year this repo's pre-commit workflow carried. TRI-1100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Aligns this repository with the org-wide setup consolidated in triton-inference-server/.github:
.pre-commit-config.yaml: shared baseline hooks, conventional-commit message validation (commit-msg stage), and the centralizedadd-licensehook from the org.githubrepository (rev: v1.4.1— excludes.github/templates, never rewrites LICENSE files).conventional-prworkflow (@v1.4.1): validates the PR title against Conventional Commits (hard gate — it becomes the squash-merge commit), derives one human-readable label per distinct type found in the title and all conforming commit subjects (e.g.ci:→CI/CD,feat:→feature,fix:→fix), enforces org-wide label colors/descriptions, detects cherry-picks, and fails if no type is derivable and no type label is assigned.Depends on triton-inference-server/.github#5 (pinned tags current:
v1.4.1— already exist, CI is green).Pros / Cons
Pros
.githubrepo) for hooks, templates, issue routing, and the PR-title workflow — one change propagates everywhere.Cons / risks
.githubrepository (tags are write-once; changes ship as a new tag + rev bump)..githubrepository to remain public.Related Issues / PRs
Related PRs:
Test plan
pre-commit validate-configpasses;pre-commit run --files <PR diff>passes locally with the centralized hooks pinned to the .github branch SHA.v1.4.1exists: the conventional-pr check validates this PR's own title and applies thecilabel.Caveats
Checklist
<commit_type>: <Title>(conventional commit)