pre-commit

Author: slorello89

.github/workflows/ci.yml

@@ -7,7 +7,7 @@ on:
     branches: ['main']
 jobs:
   tls:
-    runs-on: ubuntu-latest    
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - name: install dependencies

README.md

@@ -110,8 +110,8 @@ Optionally you may configure your `user`/`password` via environment variables. T
 
 ### TLS
 
-Transport Layer Security (TLS) can be enabled in Redis and within the Triton Redis Cache, to do so you will need a TLS 
-enabled version of Redis, e.g. [OSS Redis](https://redis.io/docs/management/security/encryption/) or 
+Transport Layer Security (TLS) can be enabled in Redis and within the Triton Redis Cache, to do so you will need a TLS
+enabled version of Redis, e.g. [OSS Redis](https://redis.io/docs/management/security/encryption/) or
 [Redis Enterprise](https://docs.redis.com/latest/rs/security/tls/enable-tls/). You will also need to configure Triton Server to use TLS with Redis
 through the following `--cache-config` TLS options.
 

examples/tls/Dockerfile

@@ -1,9 +1,9 @@
-FROM nvcr.io/nvidia/tritonserver:23.03-py3-sdk
+FROM nvcr.io/nvidia/tritonserver:23.06-py3-sdk
 
-RUN apt install -y lsb-release curl gpg 
-RUN curl -fsSL https://packages.redis.io/gpg | gpg --dearmor -o /usr/share/keyrings/redis-archive-keyring.gpg 
-RUN echo "deb [signed-by=/usr/share/keyrings/redis-archive-keyring.gpg] https://packages.redis.io/deb $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/redis.list 
-RUN apt-get update 
+RUN apt install -y lsb-release curl gpg
+RUN curl -fsSL https://packages.redis.io/gpg | gpg --dearmor -o /usr/share/keyrings/redis-archive-keyring.gpg
+RUN echo "deb [signed-by=/usr/share/keyrings/redis-archive-keyring.gpg] https://packages.redis.io/deb $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/redis.list
+RUN apt-get update
 RUN apt-get install -y redis
 
 CMD "/app/test.sh"

examples/tls/test.sh

@@ -9,7 +9,7 @@ fi
 
 numKeys=$(redis-cli -h triton-redis --tls --cert /certs/redis.crt --key /certs/redis.key --cacert /certs/ca.crt DBSIZE) # check that there's only one key
 
-if [[ $numKeys -eq 1 ]]; then    
+if [[ $numKeys -eq 1 ]]; then
     exit 0
 else
     echo "Redis did not have the expected number of keys."

src/redis_cache.cc

@@ -146,9 +146,10 @@ RedisCache::Create(
     poolOptions.wait_timeout = std::chrono::milliseconds(1000);
   }
 
-  //tls options
-  if(document.HasMember("tls_enabled")){
-    options.tls.enabled = strcmp(document["tls_enabled"].GetString(), "true") == 0;
+  // tls options
+  if (document.HasMember("tls_enabled")) {
+    options.tls.enabled =
+        strcmp(document["tls_enabled"].GetString(), "true") == 0;
     setOption("cert", options.tls.cert, document);
     setOption("key", options.tls.key, document);
     setOption("cacert", options.tls.cacert, document);