test: Add Validator

This change adds a test to validate that the modification provides the expected outcome.

Author: whoisj

python/openai/tests/test_openai_server_args.py

@@ -0,0 +1,65 @@
+# Copyright 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#  * Redistributions of source code must retain the above copyright
+#    notice, this list of conditions and the following disclaimer.
+#  * Redistributions in binary form must reproduce the above copyright
+#    notice, this list of conditions and the following disclaimer in the
+#    documentation and/or other materials provided with the distribution.
+#  * Neither the name of NVIDIA CORPORATION nor the names of its
+#    contributors may be used to endorse or promote products derived
+#    from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' AND ANY
+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+# PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE COPYRIGHT OWNER OR
+# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+# OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import pytest
+
+from ..openai_frontend.engine.utils.triton import (
+    _get_vllm_lora_names as get_vllm_lora_names,
+)
+
+
+@pytest.mark.openai
+class TestOpenAIServerArgs:
+    @pytest.mark.parametrize(
+        "model_repository,model_name,expect_error",
+        [
+            ("openai_model_repository", "", True),
+            ("openai_model_repository", "     ", True),
+            ("openai_model_repository", "invalid/path", True),
+            ("openai_model_repository", "invalid\\path", True),
+            ("openai_model_repository", "../outside/repo", True),
+            ("test_models", "identity_py", False),
+            ("test_models", "mock_llm", False),
+        ],
+    )
+    def test_invalid_model_name(self, model_repository: str, model_name: str, expect_error: bool):
+        try:
+            get_vllm_lora_names(model_repository, model_name, 1)
+        except ValueError as e:
+            if expect_error:
+                self.assertEqual(
+                    f"Invalid model name: '{model_name}'. Model names must be valid file-system-path segment names.",
+                    str(e)
+                )
+            else:
+                raise pytest.fail(
+                    f"(model_repository={model_repository}, model_name='{model_name}') raised ValueError unexpectedly: {e}"
+                )
+
+        if expect_error:
+            raise pytest.fail(
+                f"(model_repository={model_repository}, model_name='{model_name}') did not raise ValueError as expected."
+            )