test: Add Validator

This change adds a test to validate that the modification provides the expected outcome.

Author: whoisj

python/openai/tests/test_lora.py

@@ -26,6 +26,7 @@
 
 import json
 import os
+import pytest
 import shutil
 import unittest
 
@@ -34,6 +35,10 @@
 
 from .utils import OpenAIServer
 
+from ..openai_frontend.engine.utils.triton import (
+    _get_vllm_lora_names as get_vllm_lora_names,
+)
+
 
 def is_vllm_installed():
     try:
@@ -361,5 +366,39 @@ def test_lora_separator_set_for_non_vllm_formatted_models(self):
             self._test_chat_completion(client, "doll")
 
 
+@pytest.mark.parametrize(
+    "model_repository,model_name,expect_error",
+    [
+        ("openai_model_repository", "", True), # Empty string as model name.
+        ("openai_model_repository", "     ", True), # Whitespace-only model name.
+        ("openai_model_repository", "invalid/path", True),
+        ("openai_model_repository", "invalid\\path", True),
+        ("openai_model_repository", "../outside/repo", True),
+        ("test_models", "identity_py", False),
+        ("test_models", "mock_llm", False),
+    ],
+)
+def test_get_vllm_lora_name(
+    self, model_repository: str, model_name: str, expect_error: bool
+):
+    try:
+        get_vllm_lora_names(model_repository, model_name, 1)
+    except ValueError as e:
+        if expect_error:
+            self.assertEqual(
+                f"Invalid model name: '{model_name}'. Model names must be valid file-system-path segment names.",
+                str(e),
+            )
+        else:
+            raise pytest.fail(
+                f"(model_repository='{model_repository}', model_name='{model_name}') raised ValueError unexpectedly: {e}"
+            )
+    else:
+        if expect_error:
+            raise pytest.fail(
+                f"(model_repository='{model_repository}', model_name='{model_name}') did not raise ValueError as expected."
+            )
+
+
 if __name__ == "__main__":
     unittest.main()