Skip to content

Commit 4ddb678

Browse files
committed
fix: Pass utf8_range_DIR to triton-server build
The protobuf bundled with gRPC v1.81.1 (v33.5) installs utf8_range as a separate CMake package and protobuf-config.cmake references the utf8_range::utf8_validity imported target. find_package(Protobuf CONFIG) with only Protobuf_DIR set fails at generate time with 'the target was not found'. Provide utf8_range_DIR alongside Protobuf_DIR.
1 parent d1e6320 commit 4ddb678

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ if (OPENSSL_ROOT_DIR)
167167
endif()
168168

169169
set(_FINDPACKAGE_PROTOBUF_CONFIG_DIR "${TRITON_THIRD_PARTY_INSTALL_PREFIX}/protobuf/${LIB_DIR}/cmake/protobuf")
170+
set(_FINDPACKAGE_UTF8_RANGE_CONFIG_DIR "${TRITON_THIRD_PARTY_INSTALL_PREFIX}/protobuf/${LIB_DIR}/cmake/utf8_range")
170171

171172
set(_FINDPACKAGE_OPENTELEMETRY_CONFIG_DIR "${TRITON_THIRD_PARTY_INSTALL_PREFIX}/opentelemetry-cpp/${LIB_DIR}/cmake/opentelemetry-cpp")
172173

@@ -199,6 +200,7 @@ ExternalProject_Add(triton-server
199200
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/triton-server"
200201
CMAKE_CACHE_ARGS
201202
-DProtobuf_DIR:PATH=${_FINDPACKAGE_PROTOBUF_CONFIG_DIR}
203+
-Dutf8_range_DIR:PATH=${_FINDPACKAGE_UTF8_RANGE_CONFIG_DIR}
202204
${_CMAKE_ARGS_OPENSSL_ROOT_DIR}
203205
${_CMAKE_ARGS_CMAKE_TOOLCHAIN_FILE}
204206
${_CMAKE_ARGS_VCPKG_TARGET_TRIPLET}

0 commit comments

Comments
 (0)