Skip to content

Commit 9e8d45a

Browse files
committed
Update
1 parent 98f8d08 commit 9e8d45a

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

python/openai/openai_frontend/engine/triton_engine.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -991,15 +991,16 @@ def _validate_completion_request(
991991
if not isinstance(request.prompt, str):
992992
raise ClientError("only single string input is supported")
993993

994-
if request.n and request.n > 1:
994+
if "best_of" in request.model_fields_set and metadata.backend == "vllm":
995995
raise ClientError(
996-
f"Received n={request.n}, but only single choice (n=1) is currently supported"
996+
"best_of is no longer supported in vLLM backend, removed from vLLM V1 engine"
997997
)
998998

999-
if "best_of" in request.model_fields_set and metadata.backend == "vllm":
999+
if request.n and request.n > 1:
10001000
raise ClientError(
1001-
"best_of is no longer supported in vLLM backend, removed from vLLM V1 engine"
1001+
f"Received n={request.n}, but only single choice (n=1) is currently supported"
10021002
)
1003+
10031004
if request.best_of and request.best_of > 1:
10041005
raise ClientError(
10051006
f"Received best_of={request.best_of}, but only single choice (best_of=1) is currently supported"

python/openai/requirements-test.txt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
1+
# Copyright 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
22
#
33
# Redistribution and use in source and binary forms, with or without
44
# modification, are permitted provided that the following conditions
@@ -24,10 +24,6 @@
2424
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
2525
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
2626

27-
2827
# Testing
2928
pytest==8.1.1
3029
pytest-asyncio==0.23.8
31-
32-
# The latest stable version of scipy is 1.17.0 which caused segfault during tests. See TRI-620.
33-
scipy==1.16.3

python/openai/requirements.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2024-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
1+
# Copyright 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
22
#
33
# Redistribution and use in source and binary forms, with or without
44
# modification, are permitted provided that the following conditions
@@ -31,6 +31,9 @@ fastapi==0.121.2
3131
httpx==0.27.2
3232
openai==1.107.3
3333
partial-json-parser # used for parsing partial JSON outputs
34+
35+
# FIXME [TRI-641]: The latest stable version of scipy is 1.17.0 which caused segfault during tests. See TRI-620.
36+
scipy==1.16.3
3437
# Minimum starlette version needed to address CVE(s):
3538
# https://github.com/advisories/GHSA-f96h-pmfr-66vw
3639
# https://github.com/advisories/GHSA-7f5h-v6xp-fcq8

0 commit comments

Comments
 (0)