Skip to content

Commit a74116a

Browse files
committed
test: Add Validator
This change adds a test to validate that the modification provides the expected outcome.
1 parent 4653f77 commit a74116a

1 file changed

Lines changed: 57 additions & 0 deletions

File tree

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
# Copyright 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2+
#
3+
# Redistribution and use in source and binary forms, with or without
4+
# modification, are permitted provided that the following conditions
5+
# are met:
6+
# * Redistributions of source code must retain the above copyright
7+
# notice, this list of conditions and the following disclaimer.
8+
# * Redistributions in binary form must reproduce the above copyright
9+
# notice, this list of conditions and the following disclaimer in the
10+
# documentation and/or other materials provided with the distribution.
11+
# * Neither the name of NVIDIA CORPORATION nor the names of its
12+
# contributors may be used to endorse or promote products derived
13+
# from this software without specific prior written permission.
14+
#
15+
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' AND ANY
16+
# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
17+
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
18+
# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
19+
# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
20+
# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
21+
# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
22+
# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
23+
# OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
24+
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
25+
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
26+
27+
import pytest
28+
29+
from ..openai_frontend.engine.utils.triton import (
30+
_get_vllm_lora_names as get_vllm_lora_names,
31+
)
32+
33+
34+
@pytest.mark.openai
35+
class TestOpenAIServerArgs:
36+
@pytest.mark.parametrize(
37+
"model_repository,model_name",
38+
[
39+
("openai_model_repository", ""),
40+
("openai_model_repository", " "),
41+
("openai_model_repository", "invalid/path"),
42+
("openai_model_repository", "invalid\\path"),
43+
("openai_model_repository", "../outside/repo"),
44+
],
45+
)
46+
def test_invalid_model_name(self, model_repository: str, model_name: str):
47+
try:
48+
get_vllm_lora_names(model_repository, model_name, 1)
49+
except ValueError as e:
50+
self.assertEqual(
51+
f"Invalid model name: '{model_name}'. Model names must be valid file-system-path segment names.",
52+
str(e)
53+
)
54+
55+
raise pytest.fail(
56+
f"(model_repository={model_repository}, model_name='{model_name}') did not raise ValueError as expected."
57+
)

0 commit comments

Comments
 (0)