Skip to content

Commit b48425e

Browse files
committed
Update naming
1 parent 976ca52 commit b48425e

2 files changed

Lines changed: 14 additions & 12 deletions

File tree

python/openai/openai_frontend/engine/triton_engine.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ async def chat(
244244
)
245245

246246
usage = _get_usage_from_response(
247-
response, metadata.backend, RequestKind.GENERATE
247+
response, metadata.backend, RequestKind.GENERATION
248248
)
249249

250250
return CreateChatCompletionResponse(
@@ -348,7 +348,7 @@ async def completion(
348348
text = _get_output(response)
349349

350350
usage = _get_usage_from_response(
351-
response, metadata.backend, RequestKind.GENERATE
351+
response, metadata.backend, RequestKind.GENERATION
352352
)
353353

354354
choice = Choice(
@@ -392,7 +392,9 @@ async def embedding(
392392
embedding_json = _get_output(response)
393393
embedding_list = json.loads(embedding_json)
394394

395-
usage = _get_usage_from_response(response, metadata.backend, RequestKind.EMBED)
395+
usage = _get_usage_from_response(
396+
response, metadata.backend, RequestKind.EMBEDDING
397+
)
396398

397399
embedding = self._get_embedding(embedding_list, request.encoding_format)
398400
embedding_obj = EmbeddingObject(
@@ -433,14 +435,14 @@ def _determine_request_converter(self, backend: str, request_type: RequestKind):
433435

434436
# Request conversion from OpenAI format to backend-specific format
435437
if backend == "vllm":
436-
if request_type == RequestKind.GENERATE:
438+
if request_type == RequestKind.GENERATION:
437439
return _create_vllm_generate_request
438440
else:
439441
return _create_vllm_embedding_request
440442

441443
# Use TRT-LLM format as default for everything else. This could be
442444
# an ensemble, a python or BLS model, a TRT-LLM backend model, etc.
443-
if request_type == RequestKind.GENERATE:
445+
if request_type == RequestKind.GENERATION:
444446
return _create_trtllm_generate_request
445447
else:
446448
return _create_trtllm_embedding_request
@@ -489,10 +491,10 @@ def _get_model_metadata(self) -> Dict[str, TritonModelMetadata]:
489491
lora_names=lora_names,
490492
create_time=self.create_time,
491493
inference_request_converter=self._determine_request_converter(
492-
backend, RequestKind.GENERATE
494+
backend, RequestKind.GENERATION
493495
),
494496
embedding_request_converter=self._determine_request_converter(
495-
backend, RequestKind.EMBED
497+
backend, RequestKind.EMBEDDING
496498
),
497499
)
498500
model_metadata[name] = metadata

python/openai/openai_frontend/engine/utils/triton.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@
4747

4848

4949
class RequestKind(Enum):
50-
GENERATE = 1
51-
EMBED = 2
50+
GENERATION = 1
51+
EMBEDDING = 2
5252

5353

5454
def _create_vllm_generate_request(
@@ -273,7 +273,7 @@ class _StreamingUsageAccumulator:
273273

274274
def update(self, response: tritonserver.InferenceResponse):
275275
"""Extracts usage from a response and updates the token counts."""
276-
usage = _get_usage_from_response(response, self.backend, RequestKind.GENERATE)
276+
usage = _get_usage_from_response(response, self.backend, RequestKind.GENERATION)
277277
if usage:
278278
# The prompt_tokens is received with every chunk but should only be set once.
279279
if not self._prompt_tokens_set:
@@ -332,14 +332,14 @@ def _get_usage_from_response(
332332
completion_tokens = completion_tokens_ptr[0]
333333

334334
if prompt_tokens is not None:
335-
if request_type == RequestKind.GENERATE and completion_tokens is not None:
335+
if request_type == RequestKind.GENERATION and completion_tokens is not None:
336336
total_tokens = prompt_tokens + completion_tokens
337337
return CompletionUsage(
338338
prompt_tokens=prompt_tokens,
339339
completion_tokens=completion_tokens,
340340
total_tokens=total_tokens,
341341
)
342-
elif request_type == RequestKind.EMBED:
342+
elif request_type == RequestKind.EMBEDDING:
343343
return EmbeddingUsage(
344344
prompt_tokens=prompt_tokens,
345345
total_tokens=prompt_tokens,

0 commit comments

Comments
 (0)