Skip to content

Commit b54a7b7

Browse files
committed
test: Add Validator
This change adds a test to validate that the modification provides the expected outcome.
1 parent 4653f77 commit b54a7b7

1 file changed

Lines changed: 52 additions & 0 deletions

File tree

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
#!/usr/bin/env python3
2+
3+
# Copyright 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
4+
#
5+
# Redistribution and use in source and binary forms, with or without
6+
# modification, are permitted provided that the following conditions
7+
# are met:
8+
# * Redistributions of source code must retain the above copyright
9+
# notice, this list of conditions and the following disclaimer.
10+
# * Redistributions in binary form must reproduce the above copyright
11+
# notice, this list of conditions and the following disclaimer in the
12+
# documentation and/or other materials provided with the distribution.
13+
# * Neither the name of NVIDIA CORPORATION nor the names of its
14+
# contributors may be used to endorse or promote products derived
15+
# from this software without specific prior written permission.
16+
#
17+
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' AND ANY
18+
# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
19+
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
20+
# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
21+
# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
22+
# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
23+
# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
24+
# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
25+
# OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26+
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27+
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28+
29+
import pytest
30+
from ..openai_frontend.engine.utils.triton import _get_vllm_lora_names as get_vllm_lora_names
31+
32+
33+
@pytest.mark.openai
34+
class TestOpenAIServerArgs:
35+
@pytest.mark.parametrize(
36+
"model_repository,model_name",
37+
[
38+
("openai_model_repository", ""),
39+
("openai_model_repository", " "),
40+
("openai_model_repository", "invalid/path"),
41+
("openai_model_repository", "invalid\\path"),
42+
("openai_model_repository", "../outside/repo"),
43+
]
44+
)
45+
def test_invalid_model_name(self, model_repository: str, model_name: str):
46+
try:
47+
get_vllm_lora_names(model_repository, model_name, 1)
48+
except ValueError as e:
49+
print(f"Caught expected exception: {e}")
50+
51+
raise pytest.fail(f"(model_repository={model_repository}, model_name='{model_name}') did not raise ValueError as expected.")
52+

0 commit comments

Comments
 (0)