fix: Support max_completion_tokens option in OpenAI frontend#8226
Merged
Conversation
pskiran1
changed the title
pskiran1
marked this pull request as ready for review
June 5, 2025 08:43
rmccorm4
reviewed
Jun 5, 2025
richardhuo-nv
previously approved these changes
Jun 9, 2025
…ton-inference-server/server into spolisetty_max_tokens_openai
richardhuo-nv
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
max_completion_tokens.max_tokenssupport for the time being to maintain backward compatibility.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Caveats:
Background
As mentioned in the API documentation,
max_tokensis deprecated, and it is recommended to usemax_completion_tokensinstead. https://platform.openai.com/docs/api-reference/chat/create#chat-create-max_tokensRelated Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)