fix: Improve data type validation for classification#8267
Merged
Conversation
pskiran1
marked this pull request as ready for review
June 26, 2025 16:29
tanmayv25
previously approved these changes
Jun 26, 2025
mc-nv
reviewed
Jun 26, 2025
yinggeh
previously approved these changes
Jun 26, 2025
mc-nv
reviewed
Jun 27, 2025
mc-nv
reviewed
Jun 27, 2025
mc-nv
reviewed
Jun 30, 2025
mc-nv
approved these changes
Jul 1, 2025
Contributor
|
Please add description for readers convenience |
mc-nv
added a commit
that referenced
this pull request
Jul 23, 2025
Co-authored-by: Misha Chornyi <99709299+mc-nv@users.noreply.github.com>
mc-nv
added a commit
that referenced
this pull request
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
This PR is intended to avoid division by zero when
TRITONSERVER_DataTypeByteSize(datatype)returns zero forBYTESdata type.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)