Skip to content

fix: Improve validation for system shared memory register#8273

Merged
pskiran1 merged 6 commits into
mainfrom
spolisetty_pb_shm
Jul 2, 2025
Merged

fix: Improve validation for system shared memory register#8273
pskiran1 merged 6 commits into
mainfrom
spolisetty_pb_shm

Conversation

@pskiran1

@pskiran1 pskiran1 commented Jun 29, 2025 •
edited by yinggeh
Loading

Copy link
Copy Markdown
Member

What does the PR do?

This PR aims to prevent users from registering SHM keys that start with the prefix triton_python_backend_shm_region_ thereby blocking their access to the internal SHM.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 30771711

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@pskiran1 pskiran1 added the PR: fix A bug fix label Jun 29, 2025
@pskiran1
pskiran1 marked this pull request as ready for review June 29, 2025 15:54
@pskiran1
pskiran1 requested review from tanmayv25 and yinggeh June 30, 2025 05:13
@yinggeh

yinggeh commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

Please add description

yinggeh
yinggeh reviewed Jul 1, 2025
View reviewed changes
Comment thread src/shared_memory_manager.cc Outdated
yinggeh
yinggeh reviewed Jul 1, 2025
View reviewed changes
Comment thread qa/L0_shared_memory/shared_memory_test.py Outdated
This was referenced Jul 1, 2025
Merged
Merged
pskiran1 and others added 3 commits July 2, 2025 10:53
@pskiran1 @yinggeh
Update src/shared_memory_manager.cc
62247a9 
Co-authored-by: Yingge He <157551214+yinggeh@users.noreply.github.com>
@pskiran1 @yinggeh
Update qa/L0_shared_memory/shared_memory_test.py
61045aa 
Co-authored-by: Yingge He <157551214+yinggeh@users.noreply.github.com>
@pskiran1
Merge branch 'main' of https://github.com/triton-inference-server/server
d96e9d8 
 into spolisetty_pb_shm
@pskiran1
pskiran1 requested a review from yinggeh July 2, 2025 05:36
yinggeh
yinggeh reviewed Jul 2, 2025
View reviewed changes
Comment thread src/common.h Outdated
@pskiran1
pskiran1 merged commit 2e8de23 into main Jul 2, 2025
3 checks passed
@pskiran1
pskiran1 deleted the spolisetty_pb_shm branch July 2, 2025 12:19
mc-nv pushed a commit that referenced this pull request Jul 23, 2025
@pskiran1 @mc-nv
fix: Improve validation for system shared memory register (#8273)
237e464
mc-nv added a commit that referenced this pull request Jul 23, 2025
@mc-nv @pskiran1
fix: Improve validation for system shared memory register (#8273) (#8310
e2e2ae5 
)

Co-authored-by: Sai Kiran Polisetty <spolisetty@nvidia.com>
@pskiran1 pskiran1 mentioned this pull request Aug 8, 2025
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yinggeh yinggeh yinggeh approved these changes
@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25

Assignees

No one assigned

Labels

PR: fix A bug fix

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pskiran1 @yinggeh @mc-nv