Conversation
yinggeh
reviewed
Aug 19, 2025
| shm_ip1_handle = shm.create_shared_memory_region( | ||
| shm_region_names[1] + "_data", "/" + shm_region_names[1], input1_byte_size | ||
| ) | ||
| with CREATION_LOCK: |
Contributor
There was a problem hiding this comment.
We don't have issues with system shared memory. So probably we can remove it.
Contributor
Author
There was a problem hiding this comment.
lock for any creation activity for simplicity
Contributor
|
@GuanLuo You can close this PR since it was merged to r25.08, which was merged back to main already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR to Triton!
Please go the the
Previewtab above this description box and select the appropriate sub-template:If you already created the PR, please replace this message with one of
and fill it out.