ci: Response Cache memory growth test - #8363
Merged
Merged
Conversation
pskiran1
marked this pull request as ready for review
August 25, 2025 16:51
pskiran1
commented
Aug 25, 2025
| set +e | ||
|
|
||
| # Log test duration and the graph for memory growth | ||
| MAX_ALLOWED_ALLOC=2 # MB |
Member
Author
There was a problem hiding this comment.
I added this threshold value based on observations from example runs. Please let me know if you have any recommendations for configuring it.
Thank you.
Contributor
There was a problem hiding this comment.
What's the averge memory growth before your fix?
Member
Author
There was a problem hiding this comment.
It exceeds 3MB on running this test. For reference, I attached a screenshot showing memory growth before the fix.
If the fix is included, it is less than 0.5 MB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
generate_random_data.pycreates random data to trigger cache misses, insertions, and evictions.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs: triton-inference-server/core#449
Where should the reviewer start?
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Test script output - Without memory leak fix (Memory grows over time):
Test script output - With memory leak fix (Memory is stable):