Skip to content

fix: Update L0_openai to adapt TRT-LLM v1.0#8419

Closed
whoisj wants to merge 1 commit into
mainfrom
jwyman/tri-71-2509-ci-failure-l0_openai_trtllm-base
Closed

fix: Update L0_openai to adapt TRT-LLM v1.0#8419
whoisj wants to merge 1 commit into
mainfrom
jwyman/tri-71-2509-ci-failure-l0_openai_trtllm-base

Conversation

@whoisj

@whoisj whoisj commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

This change moves the import of LLM from tensorrt_llm to tensorrt_llm._tensorrt_engine to adapt the API changes in TRT-LLM v1.0.

TRI-71

@whoisj whoisj added bug Something isn't working PR: ci Changes to our CI configuration files and scripts openai OpenAI related TensorRT-LLM labels Sep 29, 2025
@whoisj
whoisj requested a review from pskiran1 September 29, 2025 17:52
@pskiran1

Copy link
Copy Markdown
Member

I quickly verified the above changes locally, and it resolves the generate_engine.py error.

@whoisj
whoisj marked this pull request as ready for review September 30, 2025 17:51
@whoisj

whoisj commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

I quickly verified the above changes locally, and it resolves the generate_engine.py error.

Thank you very much 🙇‍♂️

@whoisj whoisj closed this Sep 30, 2025
@whoisj
whoisj force-pushed the jwyman/tri-71-2509-ci-failure-l0_openai_trtllm-base branch from e35b821 to d274607 Compare September 30, 2025 17:55
This change moves the import of `LLM` from `tensorrt_llm` to `tensorrt_llm._tensorrt_engine`
to adapt the API changes in TRT-LLM v1.0.
@whoisj whoisj reopened this Sep 30, 2025
@whoisj
whoisj requested a review from yinggeh September 30, 2025 19:18
@yinggeh

yinggeh commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

I think main is still using TENSORRTLLM_REPO_TAG=release/0.21. Do you mean to merge to r25.09?

@dmitry-tokarev-nv dmitry-tokarev-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch to 25.09 branch as the target.
Main is still on trtllm 0.21

@whoisj

whoisj commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

switch to 25.09 branch as the target. Main is still on trtllm 0.21

r25.09 PR -> #8430

@yinggeh

yinggeh commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Please close this PR

@whoisj whoisj closed this Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working openai OpenAI related PR: ci Changes to our CI configuration files and scripts TensorRT-LLM

Development

Successfully merging this pull request may close these issues.

4 participants