fix: Validate model_name when Loading Model from Repository - #8427
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
whoisj
changed the title
model_name When Loading Model from Repositorymodel_name when Loading Model from Repository
whoisj
force-pushed
the
jwyman/tri-46-2509-checkmarx-triage
branch
2 times, most recently
from
September 30, 2025 19:13
445c78d to
f768007
Compare
This change adds additional validation of user input `model_name` prior to using to load a model from the repository.
whoisj
force-pushed
the
jwyman/tri-46-2509-checkmarx-triage
branch
from
September 30, 2025 19:15
f768007 to
4653f77
Compare
Christina-Young-NVIDIA
previously approved these changes
Sep 30, 2025
yinggeh
previously approved these changes
Sep 30, 2025
whoisj
dismissed stale reviews from yinggeh and Christina-Young-NVIDIA
via
September 30, 2025 22:01
b54a7b7
whoisj
force-pushed
the
jwyman/tri-46-2509-checkmarx-triage
branch
6 times, most recently
from
September 30, 2025 23:57
0f60f74 to
3b502e3
Compare
whoisj
requested review from
Christina-Young-NVIDIA and
yinggeh
and removed request for
mattwittwer
October 1, 2025 15:37
yinggeh
previously approved these changes
Oct 1, 2025
Contributor
|
Can you also add the missing tests for #8406? |
yinggeh
reviewed
Oct 1, 2025
yinggeh
self-requested a review
October 1, 2025 16:19
whoisj
force-pushed
the
jwyman/tri-46-2509-checkmarx-triage
branch
from
October 1, 2025 16:19
3b502e3 to
a74116a
Compare
This change adds a test to validate that the modification provides the expected outcome.
whoisj
force-pushed
the
jwyman/tri-46-2509-checkmarx-triage
branch
from
October 1, 2025 17:13
0ca3689 to
4b4c676
Compare
yinggeh
reviewed
Oct 1, 2025
Co-authored-by: Yingge He <157551214+yinggeh@users.noreply.github.com>
yinggeh
reviewed
Oct 1, 2025
Contributor
Nvm. Thought they were different issues. |
Co-authored-by: Yingge He <157551214+yinggeh@users.noreply.github.com>
whoisj
force-pushed
the
jwyman/tri-46-2509-checkmarx-triage
branch
2 times, most recently
from
October 2, 2025 22:27
309c238 to
a420738
Compare
whoisj
force-pushed
the
jwyman/tri-46-2509-checkmarx-triage
branch
from
October 2, 2025 22:57
03fa35d to
3500de5
Compare
yinggeh
approved these changes
Oct 3, 2025
whoisj
added a commit
that referenced
this pull request
Oct 3, 2025
Co-authored-by: Yingge He <157551214+yinggeh@users.noreply.github.com>
mc-nv
pushed a commit
that referenced
this pull request
Oct 3, 2025
…#8439) Co-authored-by: Yingge He <157551214+yinggeh@users.noreply.github.com>
mc-nv
pushed a commit
that referenced
this pull request
Oct 6, 2025
…#8439) Co-authored-by: Yingge He <157551214+yinggeh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds additional validation of user input
model_nameprior to using to load a model from the repository.TRI-46