test: Fix L0_simple_lib--base - #8431
Merged
Merged
Conversation
whoisj
reviewed
Oct 1, 2025
whoisj
left a comment
whoisj
left a comment
Contributor
There was a problem hiding this comment.
The fix looks correct-ish, but I left a question (repeated 3 times) for you.
whoisj
approved these changes
Oct 1, 2025
pskiran1
approved these changes
Oct 2, 2025
yinggeh
added a commit
that referenced
this pull request
Oct 2, 2025
mc-nv
pushed a commit
that referenced
this pull request
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Fix race condition. The
barrierobject is destructed before access in request release callbacks, leading to segfault.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/core#452
Where should the reviewer start?
Test plan:
35850970
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)