Skip to content

Add Integer Overflow Sanity Check #8489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whoisj merged 1 commit into from
Nov 6, 2025
Merged

Add Integer Overflow Sanity Check #8489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/http_server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,8 +606,14 @@ ReadDataFromJsonHelper(
const char* cstr;
size_t len = 0;
RETURN_IF_ERR(tensor_data.AsString(&cstr, &len));
if (static_cast<int64_t>(*counter + len + sizeof(uint32_t)) >
expected_cnt) {
// Quick sanity check to ensure we don't write beyond `expected_cnt`.
int32_t actual_cnt = *counter + len + sizeof(uint32_t);
if (actual_cnt < 0) {
return TRITONSERVER_ErrorNew(
TRITONSERVER_ERROR_INTERNAL,
"Unable to parse 'data' field: string length is negative");
}
if (static_cast<int64_t>(actual_cnt) > expected_cnt) {
return TRITONSERVER_ErrorNew(
TRITONSERVER_ERROR_INTERNAL,
"Shape does not match true shape of 'data' field");
Expand Down
Loading