Skip to content

Revert "fix: Improve bounds checking on integer conversions (#8612)" #8618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mc-nv merged 1 commit into from
Jan 23, 2026
Merged

Revert "fix: Improve bounds checking on integer conversions (#8612)" #8618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions src/http_server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,30 +603,21 @@ ReadDataFromJsonHelper(
break;
}
case TRITONSERVER_TYPE_BYTES: {
const char* cstr{nullptr};
size_t len{0};
const char* cstr;
size_t len = 0;
RETURN_IF_ERR(tensor_data.AsString(&cstr, &len));
if (len > INT64_MAX) {
return TRITONSERVER_ErrorNew(
TRITONSERVER_ERROR_INTERNAL,
"Unable to parse 'data' field: string length exceeds size"
" limitation");
}
// Quick sanity check to ensure we don't write beyond `expected_cnt`.
int64_t tmp_cnt = static_cast<int64_t>(*counter) +
static_cast<int64_t>(len) +
static_cast<int64_t>(sizeof(uint32_t));
if (tmp_cnt < 0 || tmp_cnt > expected_cnt) {
int32_t actual_cnt = *counter + len + sizeof(uint32_t);
if (actual_cnt < 0) {
return TRITONSERVER_ErrorNew(
TRITONSERVER_ERROR_INTERNAL,
"Shape does not match true shape of 'data' field");
"Unable to parse 'data' field: string length is negative");
}
if (tmp_cnt > INT32_MAX) {
if (static_cast<int64_t>(actual_cnt) > expected_cnt) {
return TRITONSERVER_ErrorNew(
TRITONSERVER_ERROR_INTERNAL,
"Unable to parse 'data' field: string length exceeds INT32_MAX");
"Shape does not match true shape of 'data' field");
}
int32_t actual_cnt = static_cast<int32_t>(tmp_cnt);
memcpy(
base + *counter, reinterpret_cast<char*>(&len), sizeof(uint32_t));
std::copy(cstr, cstr + len, base + *counter + sizeof(uint32_t));
Expand Down
Loading