Skip to content

ci: Ensemble requests stuck indefinitely when the step max_queue_size exceeded - #8631

Merged
pskiran1 merged 7 commits into
mainfrom
spolisetty/tri-654-bug-in-ensemble-scheduler-when-using-dynamic-batcher
Feb 11, 2026
Merged

ci: Ensemble requests stuck indefinitely when the step max_queue_size exceeded#8631
pskiran1 merged 7 commits into
mainfrom
spolisetty/tri-654-bug-in-ensemble-scheduler-when-using-dynamic-batcher

Conversation

@pskiran1

@pskiran1 pskiran1 commented Feb 2, 2026

Copy link
Copy Markdown
Member

What does the PR do?

Test coverage for triton-inference-server/core#466

Changes:

  • Added comprehensive test coverage for max_queue_size behavior in ensemble steps
  • Updated existing backpressure tests to properly handle and verify error responses

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

triton-inference-server/core#466

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 43038365

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@pskiran1 pskiran1 changed the title ci: Ensemble requests stuck indefinitely when the step max_queue_size exceeded ci: Ensemble requests stuck indefinitely when the step max_queue_size exceeded Feb 2, 2026
@pskiran1
pskiran1 requested a review from Copilot February 2, 2026 05:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a critical issue where ensemble requests could become stuck indefinitely when a step's max_queue_size was exceeded. The fix ensures proper error handling and stream termination when queue limits are reached.

Changes:

  • Added comprehensive test coverage for max_queue_size behavior in ensemble steps
  • Updated existing backpressure tests to properly handle and verify error responses
  • Modified the decoupled producer model to support batching and introduce processing delays

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
qa/L0_simple_ensemble/test.sh Added new test section for max_queue_size in ensemble steps with two scenarios (step1 and step2)
qa/L0_simple_ensemble/ensemble_backpressure_test.py Refactored response collection to handle errors, added new test class for max_queue_size validation
qa/L0_simple_ensemble/backpressure_test_models/decoupled_producer/config.pbtxt Enabled batching by changing max_batch_size from 0 to 1
qa/L0_simple_ensemble/backpressure_test_models/decoupled_producer/1/model.py Added processing delay and fixed tensor shape handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread qa/L0_simple_ensemble/backpressure_test_models/decoupled_producer/1/model.py Outdated

@whoisj whoisj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

 into spolisetty/tri-654-bug-in-ensemble-scheduler-when-using-dynamic-batcher
…-dynamic-batcher' of https://github.com/triton-inference-server/server into spolisetty/tri-654-bug-in-ensemble-scheduler-when-using-dynamic-batcher
@pskiran1
pskiran1 merged commit 8a047ad into main Feb 11, 2026
3 checks passed
@pskiran1
pskiran1 deleted the spolisetty/tri-654-bug-in-ensemble-scheduler-when-using-dynamic-batcher branch February 11, 2026 17:37
pskiran1 added a commit that referenced this pull request Feb 13, 2026
mc-nv pushed a commit that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: ci Changes to our CI configuration files and scripts

Development

Successfully merging this pull request may close these issues.

4 participants