fix: pass http max input size to SagemakerApiServer - #8634
Closed
a-ys wants to merge 2 commits into
Closed
Conversation
Author
|
Hi @mc-nv, could you take a look please? Thank you |
Contributor
|
@yinggeh - Can you also review this change? |
Contributor
|
Hi @a-ys, Thank you for your contribution. The logic of this PR is good. Before we can merge this in can you please review the Contribution guidelines and sign the Contributor License Agreement. If possible please also help resolve these pre-commit errors. I can also help resolve these if the pre-commit message is unclear. [Internal note. Pipeline: 44332733] |
yinggeh
self-requested a review
February 19, 2026 23:15
Contributor
|
Duplicate of #8686 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
The http-max-input-size argument wasn't being passed to the SagemakerApiServer. Fixes passing this argument through environment variable
SAGEMAKER_TRITON_ADDITIONAL_ARGSas documented here.Tested locally, set the http-max-input-size for a Sagemaker server to 128mb (default is 64). Verified that request size between 64-128 passes, and larger fails correctly. Didn't add a test to L0_sagemaker since it's a minor fix. Please let me know if a test is required there.
Checklist
Agreement
<commit_type>: <Title>pre-commit install, pre-commit run --all)Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)