Skip to content

fix: pass http max input size to SagemakerApiServer - #8634

Closed
a-ys wants to merge 2 commits into
triton-inference-server:mainfrom
a-ys:fix-sagemaker-max-input-size
Closed

fix: pass http max input size to SagemakerApiServer#8634
a-ys wants to merge 2 commits into
triton-inference-server:mainfrom
a-ys:fix-sagemaker-max-input-size

Conversation

@a-ys

@a-ys a-ys commented Feb 2, 2026

Copy link
Copy Markdown

What does the PR do?

The http-max-input-size argument wasn't being passed to the SagemakerApiServer. Fixes passing this argument through environment variable SAGEMAKER_TRITON_ADDITIONAL_ARGS as documented here.

Tested locally, set the http-max-input-size for a Sagemaker server to 128mb (default is 64). Verified that request size between 64-128 passes, and larger fails correctly. Didn't add a test to L0_sagemaker since it's a minor fix. Please let me know if a test is required there.

Checklist

  • I have read the Contribution guidelines and signed the Contributor License
    Agreement
  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • I ran pre-commit locally (pre-commit install, pre-commit run --all)
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@a-ys

a-ys commented Feb 9, 2026

Copy link
Copy Markdown
Author

Hi @mc-nv, could you take a look please? Thank you

@dzier
dzier requested a review from whoisj February 19, 2026 00:35
@mudit-eng

Copy link
Copy Markdown
Contributor

@yinggeh - Can you also review this change?

@yinggeh
yinggeh requested a review from mattwittwer February 19, 2026 00:53
@mattwittwer

Copy link
Copy Markdown
Contributor

Hi @a-ys,

Thank you for your contribution. The logic of this PR is good. Before we can merge this in can you please review the Contribution guidelines and sign the Contributor License Agreement.

If possible please also help resolve these pre-commit errors. I can also help resolve these if the pre-commit message is unclear.

[Internal note. Pipeline: 44332733]

@yinggeh
yinggeh self-requested a review February 19, 2026 23:15
@yinggeh

yinggeh commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Duplicate of #8686

@yinggeh yinggeh marked this as a duplicate of #8686 Apr 20, 2026
@yinggeh yinggeh closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants