Skip to content

fix: pass http max input size to SagemakerApiServer #8634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a-ys wants to merge 2 commits into from
Closed

fix: pass http max input size to SagemakerApiServer #8634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f3d2a4
fix: pass http max input size to SM apiserver
a-ys Feb 2, 2026
25acd43
Merge branch 'main' into fix-sagemaker-max-input-size
mattwittwer Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2018-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// Copyright 2018-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -183,7 +183,7 @@ StartSagemakerService(
TRITONSERVER_Error* err = triton::server::SagemakerAPIServer::Create(
server, trace_manager, shm_manager, g_triton_params.sagemaker_port_,
g_triton_params.sagemaker_address_, g_triton_params.sagemaker_thread_cnt_,
service);
g_triton_params.http_max_input_size_, service);
if (err == nullptr) {
err = (*service)->Start();
}
Expand Down
4 changes: 3 additions & 1 deletion src/sagemaker_server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,12 @@ SagemakerAPIServer::Create(
triton::server::TraceManager* trace_manager,
const std::shared_ptr<SharedMemoryManager>& shm_manager, const int32_t port,
const std::string address, const int thread_cnt,
const size_t max_input_size,
std::unique_ptr<HTTPServer>* http_server)
{
http_server->reset(new SagemakerAPIServer(
server, trace_manager, shm_manager, port, address, thread_cnt));
server, trace_manager, shm_manager, port, address, thread_cnt,
max_input_size));

const std::string addr = address + ":" + std::to_string(port);
LOG_INFO << "Started Sagemaker HTTPService at " << addr;
Expand Down
8 changes: 5 additions & 3 deletions src/sagemaker_server.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2021-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// Copyright 2021-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -45,6 +45,7 @@ class SagemakerAPIServer : public HTTPAPIServer {
triton::server::TraceManager* trace_manager,
const std::shared_ptr<SharedMemoryManager>& smb_manager,
const int32_t port, const std::string address, const int thread_cnt,
const size_t max_input_size,
std::unique_ptr<HTTPServer>* sagemaker_server);

class SagemakeInferRequestClass : public InferRequestClass {
Expand Down Expand Up @@ -73,10 +74,11 @@ class SagemakerAPIServer : public HTTPAPIServer {
const std::shared_ptr<TRITONSERVER_Server>& server,
triton::server::TraceManager* trace_manager,
const std::shared_ptr<SharedMemoryManager>& shm_manager,
const int32_t port, const std::string address, const int thread_cnt)
const int32_t port, const std::string address, const int thread_cnt,
const size_t max_input_size)
: HTTPAPIServer(
server, trace_manager, shm_manager, port, false /* reuse_port */,
address, "" /* header_forward_pattern */, thread_cnt),
address, "" /* header_forward_pattern */, thread_cnt, max_input_size),
ping_regex_(R"(/ping)"), invocations_regex_(R"(/invocations)"),
models_regex_(R"(/models(?:/)?([^/]+)?(/invoke)?)"),
model_path_regex_(
Expand Down
Loading