ci: Add model name validation for model management requests - #8672
Merged
pskiran1 merged 7 commits intoMar 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for model name validation in model management operations (load/unload). The tests verify that the server properly rejects malicious model names that could be used for path traversal attacks, as well as empty model names.
Changes:
- Added new test suite
ModelNameValidationTestto validate model name security checks - Added test execution block in test.sh to run the model name validation tests
- Updated copyright years to 2024-2026
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| qa/L0_input_validation/test.sh | Added test orchestration for model name validation tests, including server setup with explicit model control mode |
| qa/L0_input_validation/input_validation_test.py | Added ModelNameValidationTest class with tests for path traversal prevention, empty name rejection, and valid name handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
whoisj
reviewed
Feb 24, 2026
whoisj
left a comment
whoisj
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall, left a couple of comments.
whoisj
previously approved these changes
Feb 27, 2026
yinggeh
previously approved these changes
Feb 27, 2026
pskiran1
deleted the
spolisetty/tri-736-psirt-path-traversal-triton-inference-server-grpc-interface
branch
March 3, 2026 05:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
This PR adds comprehensive test coverage for model name validation in model management operations (load/unload). The tests verify that the server properly rejects malicious model names that could be used for path traversal attacks, as well as empty model names.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs: triton-inference-server/core#472
Where should the reviewer start?
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)